https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    05/04/2017, 2:19 PM
    If we can, I vote for deprecating it.
  • r

    ron

    05/04/2017, 2:20 PM
    and with 
    item()
    you can still customize like
    Copy code
    item(title) {
   customize()
  }.action { action}
  • r

    ron

    05/04/2017, 2:20 PM
    ?
  • e

    edvin

    05/04/2017, 2:24 PM
    Yes, but you can write the action inside the first op block, it looks nicer.
  • k

    kastork

    05/04/2017, 2:24 PM
    I'm back... thanks for the pointers, will re-work it
  • e

    edvin

    05/04/2017, 2:24 PM
    @User uploaded a file: Untitled
    -.kt
  • e

    edvin

    05/04/2017, 2:26 PM
  • e

    edvin

    05/04/2017, 2:26 PM
    It's possible 🙂
    👍 2
  • k

    kastork

    05/04/2017, 2:33 PM
    So I'm guessing this is wrong too
  • k

    kastork

    05/04/2017, 2:33 PM
    Copy code
    form {
				fieldset("Toolbox Global Setup") {
					field("Downloaded Archives Directory") {
						textfield(preferencesModel.archivesLocation) {
							setOnAction { println("Foo") }
						}
						button("...") {
							setOnAction {
								preferencesModel.archivesLocation.value = chooseDirectory(
										"Downloaded Archives Directory",
										File("/"))!!.absolutePath
							}
						}
					}
  • k

    kastork

    05/04/2017, 2:34 PM
    because the file browser dialog ignores the first click on the "open" button
  • e

    edvin

    05/04/2017, 2:37 PM
    No that's correct, but you can use 
    action
    instead of 
    setOnAction
    . If it ignores your first call it must be due to something else.
    👍 1
  • e

    edvin

    05/04/2017, 2:38 PM
    Changing 
    menuitem
    to 
    item
    will be easy, since the refactoring can be done on the whole project in one go 🙂
  • e

    edvin

    05/04/2017, 2:44 PM
    Committed: Deprecated 
    menuitem
    builders in favor of 
    item
    builders, which work the same way as other builders with respect to action (IDEA provides quick fix)
  • e

    edvin

    05/04/2017, 2:45 PM
    @thomasnield If/when you have time: Can you check that IDEA will automatically convert your 
    menuitem
    builders to 
    item
    builders flawlessly? It should be a single action, and it can update the whole project.
  • e

    edvin

    05/04/2017, 2:45 PM
    Testing on the CRM now, it has lots of these things.
  • k

    kastork

    05/04/2017, 2:50 PM
    @edvin the dialog comes up as expected, but after selecting a directory, the dialog's 'open' button does not respond the first time it is clicked
  • e

    edvin

    05/04/2017, 2:51 PM
    @kastork That dialog is not a TornadoFX thing. What version of Java are you running?
  • k

    kastork

    05/04/2017, 2:51 PM
    jdk1.8.0_121
  • k

    kastork

    05/04/2017, 2:52 PM
    kotlin 1.1.2-2
  • e

    edvin

    05/04/2017, 2:52 PM
    Weird. Could you create a small standalone sample that shows the same issue?
  • e

    edvin

    05/04/2017, 2:53 PM
    I was able to successfully migrate all my old menuitem builders to item with a single click in IDEA. Success :))
  • k

    kastork

    05/04/2017, 2:53 PM
    yeah, some other chores first though
  • e

    edvin

    05/04/2017, 2:56 PM
    I updated the guide with respect to menuitem -> item
  • e

    edvin

    05/04/2017, 2:56 PM
    OK @kastork
  • e

    edvin

    05/04/2017, 3:00 PM
    @thomasnield I feel less bad about deprecating the menuitem builder now that I know you can update your project with a single click 🙂 hehe..
    👍 1
  • k

    kastork

    05/04/2017, 3:24 PM
  • k

    kastork

    05/04/2017, 3:25 PM
    I'm running off HEAD of TornadoFX repo
  • r

    Ruckus

    05/04/2017, 3:31 PM
    @kastork It works fine for me
  • k

    kastork

    05/04/2017, 3:32 PM
    @Ruckus I wonder if it is a macOS thing
1...114411451146...2007Latest