@User uploaded a file: Untitled

thanks to that dang keyboard thread the other day I’m now lusting after an ErgoDox even though I already have a Kinesis Advantage 1 and 2

😠

@alexp11223 for the mainview, move your code to the App

@edvin. should i write a ticket for Alex P's problem? IMHO onDock should have a valid window. the problem is that in the main view, App.start is calling onDock before setStage (and onBeforeShow, etc)

I think onDock is your goto replacement for onShown, so onBeforeShow (onBeforeDock) should be called before onDock

@carlw I think you're right.

Let me have a quick look.

sure. i know it's late. do you want me to type up an issue with the test case? Alex P has a workaround for now

I see the issue. If you can create an issue that would be great, Carl 🙂

Will figure it out tomorrow 🙂

onDock

of the primary view is triggered by

createPrimaryScene

because it calls

Scene(view.getRootWrapper())

.

When the scene of a view root is changed,

onDock

is called.

I could mute docking for this particular use case and just call onDock when everything is set up. That might be a good thing to do for a main view.

The

currentWindow

implementation is also flawed. It needs to check the modalStage, because the root might not have a scene.

Alex P's issue is #331

i think the problem with currentWindow is also semantics. is that the owner or the Stage closest to the UI control?

I committed a fix for it. Might need some more work tomorrow 🙂 Good night guys!

Is there an easy way to get a statusbar(hbox) under the bottom drawer in the workspace? Basically exactly the same as how IntelliJ looks

@nyxcharon I think it is possible to wrap the whole workspace... in, say, a border layout

but I forget where I saw that idea

and how it works

@edvin btw after fixing the currentWindow, maybe it would be a good idea to add properties like

minWidth/Height

to it to avoid casts? Or

minWindowWidth/Height

to

View

or something like this:

I added these:

@User uploaded a file: Untitled

@nyxcharon There is a

wrapper

builder that lets you create a node that will be the new root of a View or Workspace. Inside there you would need to set the root as a child somewhere. For example:

@User uploaded a file: Wrap the Workspace root Node

I'm happy to see this come in handy. I thought I might be the only user of this feature for a long time.. hehe

Http status code enums for Rest.Response: https://github.com/edvin/tornadofx/issues/330

@edvin I like how you content yourself by replacing "cups" with "shots" 😄