This technique is essentially the same used to open a modal window and block.

Here is the new implementation:

@User uploaded a file: AwaitUntil

Notice also that it only fires once, so I need to click the button to start listening again for the second time.

It's committed now.

@alexp11223 Would you need an atmost timeout parameter as well?

could be useful, though not really important. More important is that it should not swallow any uncaught exceptions (and propagate them to the main thread). But as I understand it already works that way

That's right :)

Is there a feature in TornadoFX for app-wide keyboard shortcuts? I put these on a Scene and was wondering if there was a shorthand syntax for doing this.

@carlw There is the

shortcut

function that will make them global within the Stage.

btw about shortcuts, is there any way to get shortcut (key combination, like Ctrl+S) text? To use it like this:

button("", imageview("save.png")) {
                shortcut("Shortcut+S")
                tooltip("Save ($shortcutText)")
            }

I tried this, but looks like

accelerators

is global

val UIComponent.shortcutText: String
    get() = accelerators.keys.firstOrNull()?.displayText ?: ""

@edvin This is working for me

@alexp11223 Does something like this work on your platform?

shortcut(KeyCodeCombination(KeyCode.S, KeyCombination.SHORTCUT_DOWN), { println("shortcut")})

yes, on windows

ubuntu / unity is intercepting all my key commands with that modifier

@edvin What do you think of this code? I'm using these command objects in two places (so far). One is on a button, the other is in this key command.

@User uploaded a file: + and - on a listview

(Besides the fact that I had to bring out a horrible full-sized Dell keyboard to test this)

@carlw As far as I cal tell, you're not using the commands in a useful way if you're just calling execute on them manually. You might as well just call a function called

compute()

instead. Or am I missing something?

We should add special support for binding shortcuts to commands though.

Right, that's what i do in my javafx apps. i delegate to the model through the viewmodel

But then you don't need or use the command pattern?

i'm going to keep going and see what happens with more viewmodels involved. i think the commands will be more useful when it's not convenient or desired to have one viewmodel hold all the global functionality

Why don't you do

command = commands.computeCommand

instead of

action { commands.computeCommand.execute() }

?

is that available to a textfield?

@carlw Yes 🙂

If you want to pass in a param you can even do

command = commands.computeCommand with param

The

param

can even be an ObservableValue. In that case, the value of the observable would be extracted at execution time and passed to the action.