@carlw I also added an overload for

shortcut

so you can do

shortcut("Shift+=", commands.addCommand)

instead of

shortcut("Shift+=", { commands.addCommand.execute() })

.

the textfield.command was added after 1.7.4?

Yes, probably in 1.7.5.

I think we added

TextField

,

ChoiceBox

and

MenuItem

in 1.7.5.

got it. it's in 1.7.5

Take that with a grain of salt though.

Great!

@edvin is there a reason you picked handler over filter for the shortcuts? I'm using that global + shortcut and don't want to transmit that value to any of my textfields

@carlw Not sure I understand. The EventHandler implementation is used as a filter, added using

scene.addEventFilter

.

ah. sorry. it's a filter

Yeah, there is a changelistener on the scene though, that makes sure the filter is always attached to the current scene for the UIComponent.

i thought my +'s would be filtered out of my textfields because they were intercepted by an accelerator

I see. But it works as expected, right?

not quite. i expected the accelerator to consume the key event and not propagate it to the textfield. i'm going to look over some old code to see what I did with this in a non-tornadofx setting.

I think the key event is propagated to the textfield first, because the even is indeed consumed by the accelerator filter when it arrives there.

does shortcut() put the event on the scene?

@edvin do you think a sliding panel would be a good candidate for replaceWith?

@carlw Absolutely, it should be.

what about something like this at 7:28

I suspect that would be pretty easy, but @Ruckus is the specialist in this area 🙂

maybe he can code a kindaReplaceWith() function for me? 😃

Haha 🙂

hm. I copied menubar example from guide and got weird errors:

Error:(10, 21) Kotlin: Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
public final fun Drawer.item(uiComponent: KClass<out UIComponent>, scope: Scope = ..., params: Map<*, Any?>? = ..., expanded: Boolean = ..., showHeader: Boolean = ..., op: (DrawerItem.() -> Unit)? = ...): DrawerItem defined in MainView
Error:(13, 21) Kotlin: None of the following functions can be called with the arguments supplied: 
public fun <http://Menu.menu|Menu.menu>(name: String? = ..., op: (Menu.() -> Unit)? = ...): Menu defined in tornadofx
public fun <http://Menu.menu|Menu.menu>(name: String? = ..., graphic: Node? = ..., op: (Menu.() -> Unit)? = ...): Menu defined in tornadofx
Error:(18, 21) Kotlin: Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
public final fun Drawer.item(uiComponent: KClass<out UIComponent>, scope: Scope = ..., params: Map<*, Any?>? = ..., expanded: Boolean = ..., showHeader: Boolean = ..., op: (DrawerItem.() -> Unit)? = ...): DrawerItem defined in MMainView
Error:(21, 21) Kotlin: Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
public final fun Drawer.item(uiComponent: KClass<out UIComponent>, scope: Scope = ..., params: Map<*, Any?>? = ..., expanded: Boolean = ..., showHeader: Boolean = ..., op: (DrawerItem.() -> Unit)? = ...): DrawerItem defined in MMainView

@User uploaded a file: Untitled

@alexp11223 There is not item builder that takes the shortcut as a string, and no menu builder that takes shortcuts at all. Let me see if I can add them.

@alexp11223 I think those examples were just renamed when we added the new versions, but they didn't have the same arguments.

@alexp11223 Just committed a fix.

I added an interesting approach to supporting Spring dependency injection, particularly for SpringBoot: https://github.com/edvin/tornadofx/issues/334#issuecomment-304455112

oh. I just tried awaitUntil, apparently I missed some important things last night. JUnit test methods (even with TestFx) obviously do not run in FX thread. So all code there (viewmodel asserts and sync code) are not executed in FX thread (which I guess is not good) ... and

awaitUntil

of course fails with exception about thread because of that