I've added a method that I can use to terminate the code

Cause it's a connection to a server

So I can send a packet to terminate the connection

Not sure where to plop the call though

can you send the same packet when you close the last Stage?

Well the problem is that I can only really instantiate the object in the first View of my app...

This might give you some ideas. It's a JavaFX Netty client. The ongoing websockets process is running after being Connected in a JavaFX Task. The handler of the websockets client is calling JavaFX with updates. A JavaFX task is used for disconnect too. http://bekwam.blogspot.com/2016/03/a-javafx-netty-websocket-client.html

Trying to figure out how to get around that so I can have it in a position to be stoppable when I need it to

Unfortunately, it's not TornadoFX

Usually, if you want to break out of a JavaFX Task, you'll work with the Task.cancel method but your code needs to check the isCancelled flag.

Well I suppose the task would end if I close the connection to the server

Correct?

If that's the case, I just need to figure out how I can do something like instantiating the client to a variable in the App where I can disconnect in stop()

are you able to post a sanitized version of your runAsync?

@User uploaded a file: Untitled

Have you seen the onUndock function? That's like Stage's onHidden and can be used for a cleanup routine like your disconnect.

If you have trouble with the process ending cleanly, I'd also try putting a temporary button alongside the runAsync/client.connect and see if doing the connection followed by a manual disconnect() ended things cleanly. Then, if that works, automate it using the Stage method.

Ex, press connect then press disconnect, then close the Stage

Not sure why, but if I move my client up to the top level, assign it a value in the action of my button, and try to call disconnect in onUndock, nothing seems to happen

Any luck keeping the client where it is and using a temp button?

For the disconnect

Yeah, it works fine

But it doesn't get called onUndock

@thomasnield Thanks, I keep forgetting about JitPack :)

@redrield Could you override stop in your app class perhaps? If not, can you post a small sample? Also interested to see where undock isn't called.

@edvin what do you think about having him return an IRCClient object from the runAsync and setting it to a field in the ui() method? Then you could use that to prevent a disconnect Of an unconnected object. Also he can bind runningProperty to something to track things in transit

That's what I'm doing in the javafx netty example I posted

I am looking at commands now, how much experimental they are now? 🙂 Is there any major breaking changes planned?

@alexp11223 I think the API should be good by now. Pretty happy with them, although I haven't started using them in my own apps yet, so I don't have much experience with them really. I like the concept a lot.

@alexp11223 Thanks for the PR. I actually had that boolean observable shortcut early on, don't know why I removed it. It should be there for sure 🙂