hm. I tried to use read only properties and found out that it requires much more boilerplate (+no auto generation by TornadoFX plugin 🙂 ) Or is there are better ways than this?

@alexp11223 We don't currently have anything for this, but I can see the benefit it would provide. We should definitely add it 🙂

@edvin looks like a bug in eventbus. Output:

jjj
ConcurrentModificationException

@User uploaded a file: Untitled

@alexp11223 Thank you, fixed 🙂

@edvin https://gist.github.com/Redrield/effb4aebeb754d6630fb071a8bd49b53

That's my code

And I'm not sure how I could inject a value into the App when I'm able to instantiate the client so that I could override stop and handle it there

@redrield Would you have several instances of IRCClient in your app or just one?

Preferably just one

Not sure how it would work with separate instances

@User uploaded a file: Alternative 1 with ViewModel

@User uploaded a file: Alternative 2 with Controller

@User uploaded a file: Better alternative: Actually using the strength of the ViewModel :)

@redrield Here is a gradual modification of your code. The last alternative is by far the best, because it removes the boiler plate and field handling in the UI by binding the input fields to the view model and calling commit before connect. Now it is also trivial to implement validation for each field.

Problem with the third one is that I'm looking to make the core modular

I don't want to build a dependency on tornadofx

Right now all I have for dependencies is netty guava and guice on the actual code that contains the client, and I have the code working with tornadofx in a subproject

Also, the first method is throwing an NPE when stop() is called

The client seems to be null

@redrield You don't need a dependency on TornadoFX in your IRCClient. You keep just the

IRCClientModel

in your TornadoFX project.

For alternative 3? I'd need TFX to get the properties

Wouldn't I?

@redrield No, they are part of Java, you just have to implement the vars manually, or skip them entirely.

@redrield I get no error on Alternative 1?

@redrield You don't even need observable values in the IRCClient, let me change and show you.

@User uploaded a file: Immutable, plain Java IRCClient

You handle instantiation of the IRCClient in

onCommit

in this case, but you could just as well have done it in your

Submit

handler.

@redrield With this approach you can also use the validation framework in TornadoFX to help you with meaningful error messages.

I don't know