https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    05/31/2017, 4:00 PM
    @kasrasadeghi The fragment is created before it is assigned a specific cell and therefore supposed to show a certain value. The binding against 
    itemProperty
    will make sure that it behaves correctly at runtime, and that also explains why you see the correct value in platform.runLater - because at that time the fragment was assigned a specific cell/value. You cannot rely on extraction of the value while you create the fragment, nor should you need to.
  • k

    kasrasadeghi

    05/31/2017, 4:01 PM
    So the fragment is just a place in the list, not a list item itself.
  • k

    kasrasadeghi

    05/31/2017, 4:02 PM
    But then how do I actually get the title to show in the titledpane?
  • e

    edvin

    05/31/2017, 4:04 PM
    @kasrasadeghi That should work as you did, basically: 
    init { titleProperty.bind(entryModel.command)
    - provided that command is a textProperty bound correctly in the ViewModel. If this doesn't work, I suspect an error in the ViewModel - please post it if so. Also, your label can be created and bound to at the same time: 
    label(entryModel.output)
    - no need to do that `textProperty().bind(entryModel.output)`:)
  • k

    kasrasadeghi

    05/31/2017, 4:05 PM
    Copy code
    class EntryModel(property: ObjectProperty<Entry>) : ItemViewModel<Entry>(itemProperty = property) {
  val command: StringProperty  = bind(autocommit = true) { item?.commandProperty }
  val output : StringProperty  = bind(autocommit = true) { item?.outputProperty  }
  val error  : BooleanProperty = bind(autocommit = true) { item?.errorProperty   }
}
  • k

    kasrasadeghi

    05/31/2017, 4:06 PM
    Copy code
    class EntryFragment : ListCellFragment<Entry>() {
  val entryModel: EntryModel = EntryModel(itemProperty)

  override val root = titledpane(entryModel.command) {
    label(entryModel.output) {
      toggleClass(KermStyle.warning, entryModel.error)
    }
  }
}
  • e

    edvin

    05/31/2017, 4:06 PM
    That looks correct to me.
  • k

    kasrasadeghi

    05/31/2017, 4:07 PM
    when trying to run the second one, hovering over entryModel.command gives the error
  • k

    kasrasadeghi

    05/31/2017, 4:07 PM
    "Error:(145, 34) Kotlin: Type mismatch: inferred type is StringProperty but String? was expected"
  • k

    kasrasadeghi

    05/31/2017, 4:07 PM
    and hovering over label gives the very strange error
  • e

    edvin

    05/31/2017, 4:07 PM
    Ah, I didn't realize you got an error, I thought you just got the wrong value.
  • k

    kasrasadeghi

    05/31/2017, 4:07 PM
    "Error:(146, 5) Kotlin: Cannot inline bytecode built with JVM target 1.8 into bytecode that is being built with JVM target 1.6. Please specify proper '-jvm-target' option"
  • e

    edvin

    05/31/2017, 4:08 PM
    So the issue is exactly that - you need to change to jvmTarget 1.8. This is described in the release notes for version 1.7.1 as well as on the README for the project at github. Let me find a reference for you.
  • e

    edvin

    05/31/2017, 4:08 PM
  • k

    kasrasadeghi

    05/31/2017, 4:08 PM
    I've looked at trying to put a jvmTarget option in Maven, but I never managed to figure it out.
  • e

    edvin

    05/31/2017, 4:08 PM
    It's described how you should do it for Maven on that link.
  • k

    kasrasadeghi

    05/31/2017, 4:09 PM
    Let me try that.
  • k

    kasrasadeghi

    05/31/2017, 4:10 PM
    Alright, so now label works fine, but there is still the type mismatch for entryModel.command.
  • n

    nimakro

    05/31/2017, 4:11 PM
    @kasrasadeghi Well that's because you are passing a StringProperty to the 
    titilepane
    builder which is expecting a string
  • n

    nimakro

    05/31/2017, 4:11 PM
    You have to to
    Copy code
    titledpane {
      titleProperty().bind(entryModel.command)
    }
  • e

    edvin

    05/31/2017, 4:12 PM
    Hm... maybe we should have one that accepts an observablevalue<String> as well.
    👍 1
  • k

    kasrasadeghi

    05/31/2017, 4:12 PM
    label works fine with an ObservableValue<T>
  • k

    kasrasadeghi

    05/31/2017, 4:12 PM
    I believe that would make sense.
  • e

    edvin

    05/31/2017, 4:14 PM
    Committed 🙂
  • k

    kasrasadeghi

    05/31/2017, 4:14 PM
    titleProperty as a function does not exist, but titleProperty as a value does.
  • k

    kasrasadeghi

    05/31/2017, 4:14 PM
    when attempting to bind to the value, like so
  • k

    kasrasadeghi

    05/31/2017, 4:14 PM
    Copy code
    override val root = titledpane {
    titleProperty.bind(entryModel.command)
    label(entryModel.output) {
      toggleClass(KermStyle.warning, entryModel.error)
    }
  }
  • k

    kasrasadeghi

    05/31/2017, 4:14 PM
    the correct value still does not show up
  • k

    kasrasadeghi

    05/31/2017, 4:15 PM
    which is strange, because it does in the label
  • e

    edvin

    05/31/2017, 4:15 PM
    @kasrasadeghi The 
    titleProperty
    as a value is coming from the Fragment itself. It's called 
    textProperty()
    on the TitledPane.
1...123312341235...2007Latest