though even if cellFormat can't work with textfield, might be worth adding a warning or documentation at least.

@ktw I fixed it instead. Just committed: Calling

cellFormat

on a TableCell that already has a formatter will now add the new formatter as a decorator instead of overwriting the old

@ktw Do you have time to test it with your application? You just need to compile and install the latest locally, then change cellDecorator to cellFormat again 🙂

thats cool.

yeah sure. I'll test it

Thank you 🙂

@edvin is it committed? I can't see it on github

@ktw Sorry, I committed it locally and started celebrating instead of pushing the change 🙂

Pushed now 🙂

@edvin I've missed a couple deadlines doing that 🙂

@Ruckus Haha 🙂 Yeah, I have so many years with svn behind me that I don't always think about the fact that we're using distributed version control systems these days.

@nimakro It was you that was going to buy the Ergodox, wasn't it?

@edvin tested it. cellFormat still doesn't work. Here's my code

@User uploaded a file: Untitled

Checking.

@ktw You're right, I see it now. Hang on.

@ktw Fixed 🙂

@edvin thanks, works 👍

Great! I might have made a mistake implementing this fallback though. The cellDecorator runs for any cell, while cellFormat only runs for cells that have content. This might represent a change in behavior for some. I will make sure to fix that before release.

yeah I was wondering what the difference was between cellFormat and cellDecorator if you could just fall back to celldecorator

@edvin btw neither cellformatter or cellDecorator work if useTextField is called after.

@ktw Yes, because that one simply overwrites the

cellFactory

. I'll see if I can do a reverse trick for that as well.

yeah I noticed that. Not sure what the best approach is but if changing the call order produces different results it can be hard to track down

Indeed. I need to go, will try to fix this a little later tonight 🙂

ok, thanks for the quick response

@ktw I looked closer at this. It's easy to merge two

cellFormat

callbacks, but it's not trivial to combine two cellFactory implementations, since they both generate a cell, and only one of them can be used. So when you have called

useTextField

, we need to keep using the cell provided by the first factory and only augment the call with the new formatter function. It does make sense to "fall back" to a decorator for cellFormat if there is an existing cell factory, and I've now made sure it haves as closely to how it would if there was no prior cell factory, so I think this way we'll have the least number of surprises. Looking at the other way around now - first declaring

cellFormat

and then calling

useTextField

.

ok, sounds good

@edvin Yes I am planning on buying one.. Why? Sorry for the late response had to practice my presentation after I came home from work...geez it's so hard to fit this all in 20 mins I actually had to get ride of a few slides... I am no only talking about view's, type-safe-builder and the viewmodel now 🙈

@nimakro Wow! I havent even walked through my whole presentation once yet, so I have no idea how much time mine will use. I know it's not complete yet. Doing the first complete run on Sunday.

@nimakro I have ordered an ErgoDox EZ. Started playing with the layout. The biggest "mistake" they did IMO is not having Space on the right thumb.