IDEA: Ultimate 2017.2 :: Kotlin: 1.1.3-2

@pim Can you try running the tests in IDEA? (right click on test.kotlin and choose

Run 'All Tests'

?

Don't they all run at each

install

?

They do, but like I said, when I run the tests in maven they all pass, but running through IDEA (the way I just said) I get 2 failures.

I can't find the reason for the discrepancy.

Oh that's what you meant with 'through IDEA' 🙂

Also, it only runs 250 tests in maven, but 304 in IDEA...

No, I meant using IDEA's build in test runner

Nope, same failures

Hmm... I wonder what's going on

Well, maybe they're part of the 54 tests not run via maven?

good point! in that case, the failing test is probably not run in maven

@edvin any reason why org.testfx (core and junit), junit, glassfish, httpclient and fontawesomefx's versions are hardcoded in the pom

There are properties for kotlin.version and dokka.version though?

But why are those 54 tests not run? I can't see anything about a hard limit of 250 anywhere.

Wait...

Does IDEA run the test apps as well

No, they're not annotated as tests.

I was just about to say that

Someone should check for library updates, but I gtg for a bit, sorry 🙂

Oh crap. I just figured it out.

Maven is only running tests from files named "...Test.kt" and none from "...Tests.kt" (note the trailing s).

Good catch!

Yep, renaming from

StylesheetTests.kt

to

StylesheetTest.kt

made it fail.

Looks like we have 10 badly named test classes: - BindingTests - ComponentTests - JsonTests - ListTests - NodeTests - RestClientTests - ScopeTests - StylesheetTests - ValidationTests - ViewModelTests

And it looks like the only way to fix it is to either rename them all and hope we don mess up the names in the future, or use the surefire plugin and change the includes.

@pim It would be cleaner to specify all versions as properties for sure.

@Ruckus Nice! Maybe we should do both? Rename the tests, and say that this is the structure we're using, but also force every test in the test package?