I shudder to think of it

@ron post how many commits you're behind!

oh gods I dont even want to think about that 😉

I remember last that the tree was now loadable like a table, so it could grow when needed

never do puppet and infrastructure work at the previous company I was, it was BAD

hmmz seems that was in 1.7.2 in april

That's not too bad.

is the book uptodate with all the changes?

@ron Not everything, but most of the important changes have been described. We really need more contributions to the guide though.

BTW remind me to send you a picture of a BBQ restaurant in Norway that apperently is so good, it is mentioned in a dutch bbq magazine I subscribe too

@ron Wow! Let me know about it, I will do you the favor of confirming that.

@edvin Good call on not moving to SO documentation: https://meta.stackoverflow.com/questions/354217/sunsetting-documentation/

@Ruckus Lucky break :)

Should we do a release? We have lots of good stuff in this one. I know there are more in the pipe line, but I guess that will always be the case 🙂

@edvin Should we merge in the animation enhancements PR?

@edvin Seems like a good point to release, might want to wait until I've had some time to test the thingy though. The animation helpers deserve their own release @Ruckus 😄

"Form and Field properties got updated to the new more concise syntax propertyName() vs. property" Is this considered a best practice? I don't understand the requirement for it since it's just more boilerplate, kotlin creates getters anyway, right

@pim TornadoFx started out with nameProperty() since that's the convention in java, but like you said kotlin provides getters and setters for properties by default, so we decided that it is more the kotlin/tornadoFx way to use the properties directly (nameProperty).

@nimakro Ah, I understood it the wrong way :)

@Ruckus Yes, let's do it. It all looks good!

@edvin Also, what about a fix for Maven not running all the tests? Should we file an issue for it and fix it in the next release?

@Ruckus Would it be fixed just by renaming the classes?

Yes, but it would still be prone to breaking if we accidentally make more with a final

s

again. That should be good enough for now, but we may want to look into a more robust, long-term solution.

I'll be afk for a while

Yeah. In any case, getting the tests to run is pri 1. I'll rename them right now.

Committed.

There was even a failing test in there, but only because there was another binding added to a test model, and we checked how many properties were being committed by overriding onCommit

@nimakro Fantastic work on the color annotator feature. Thank you! So happy that you are contributing so much to the plugin! I think there is a bug with converting properties to javafx properties. I will deal with that, then we'll release a new plugin version together with the TornadoFX version.

@edvin Hey you are very welcome. I actually noticed the bug with the properties as well just didn't get around to fix it yet. So go for it. Just played around with the ViewEditor a bit but man I am so bad ad

Psi

stuff 🙈 I think I will also add some error hints to the color annotator so if you do

c(1.4, -1, 0.0)

it will tell you that you are only allowed to use values between 0.0 and 1.0. I will do the same for 0 and 255. I also plan on having a color annotator for

backgroundColor

but I will have to introduce a new control for that which will list the different colors assigned to the background property 😀

@edvin I thought there were 2 failing tests