kotlinlang #tornadofx

If i am using the index way it's working fine but when i use the tab instance way it adds two instances of the same tab one is empty another one is fine (with focus).

edvin

08/29/2017, 1:31 PM

Post your code (as text)

edvin

08/29/2017, 1:31 PM

I just added a Tab.select() for easier selection of tab without having to access tabPane.selectionModel

edvin

08/29/2017, 1:32 PM

So with head you could even just do

tab(uicmp).select()

aayush

08/29/2017, 1:34 PM

Copy code

class TabbedView : View() {

    override val root = tabpane {

            add(DashboardTab::class)

            subscribe<AddTab<*>> {
                val uicmp = find(it.type)
                if (tabs.map { it.content }.none { it == uicmp.root }) {
                    add(uicmp)
//                    selectionModel.select(tabs.size - 1)
                    //////////<<<<OR>>>/////////////////////
                    val tab = tab(uicmp)
                    selectionModel.select(tab)
                }

            }
        }
}

edvin

08/29/2017, 1:34 PM

@aayush You're doing both add() and tab() - you only need to do one, so remove the add() line.

aayush

08/29/2017, 1:35 PM

ohhh ..got it now 🙂

edvin

08/29/2017, 1:36 PM

@aayush Also, when you post code samples, click the + button and select "Code or text snippet", make sure to choose "Kotlin" as the code type, then you get syntax hl for your code, which makes it more pleasant to read 🙂

👍 2

edvin

08/29/2017, 2:15 PM

I added a few extra bells and whistles so you can now just do

if (!contains(uicmp)) tab(uicmp).select()

👍 1

edvin

08/29/2017, 2:16 PM

Ie. TabPane has a contains(UIComponent) function

javidev

08/29/2017, 7:22 PM

Hey @edvin, sorry about the delay, I'm on a very different timezone apparently. So I wrote a test to show you what I'm trying to do, it fails on the very last line.

Copy code

data class PojoClass(val name: String)

class PojoViewModel : ItemViewModel<PojoClass>() {
    val name = bind(PojoClass::name)
}

class ItemViewModelTest {

    @Test
    fun testCommit() {
        FxToolkit.registerPrimaryStage()
        val model = PojoViewModel()
        model.item = PojoClass("original")
        Assert.assertTrue(model.item.name == "original")

        model.name.value = "modified"
        Assert.assertFalse(model.item.name == "modified")
        Assert.assertTrue(model.isDirty)

        model.commit()
        Assert.assertTrue(model.item.name == "modified")
    }
}

edvin

08/29/2017, 8:42 PM

@javidev The reason this can't work is that your data class is immutable. There is no way for the ViewModel to write changes back to it.

edvin

08/29/2017, 8:43 PM

If you change

val name: String

var name: String

it should work.

edvin

08/29/2017, 8:43 PM

@javidev If you want to keep it immutable, you'd have to listen for commits and create a new item based on the values in the viewmodel.

edvin

08/29/2017, 8:44 PM

@User uploaded a file: Untitled

-.kt

edvin

08/29/2017, 8:44 PM

Does that make sense?

javidev

08/29/2017, 9:27 PM

oh it makes perfect sense

javidev

08/29/2017, 9:28 PM

now, I went back and found out that in my project, the pojo classes have nullable fields like

var name : String? = null

javidev

08/29/2017, 9:28 PM

I changed the test into

data class PojoClass(var name: String? = null)

javidev

08/29/2017, 9:28 PM

and it broke again

javidev

08/29/2017, 9:29 PM

is that supposed to happen?

javidev

08/29/2017, 9:29 PM

having the onCommit listener though feels like a lifesaver

edvin

08/29/2017, 9:41 PM

@javidev That might be a bug. It should be able to push the value back into

var name: String? = null