I did a binary search on the commits and didn't see a version that didn't have a KClass param @edvin

(Maybe one that was never committed?)

Yep, I saw edvin added it and now he says it can go, so it was just a experiment, which resulted to wrong code (it was added under experimenting). I'm adding the "real" usage, to the code and removing this one. thx again

@tieskedh It's used a lot, but it doesn't need to be reified.

@tieskedh I think however that it would be possible to consolidate a lot of the add functions. Half are for

View

and the other half is for

Fragment

. I think it's possible to merge them.

@edvin I added 2 inline functions, which also use varargs instead of map. with these usage, you can use

add<SubFragment>(
         SubFragment::booleanParam to false,
         SubFragment::nullableBooleanParam to null
    ){
        subFragmentWithParam = this
    }

Instead of

add(SubFragment::class, mapOf(
       SubFragment::booleanParam to false,
       SubFragment::nullableBooleanParam to null
   )){
        subFragmentWithParam = this
    }

I will look if some can be merged

@tieskedh Perfect!

@tieskedh Great work on smartResize. In addition to cleanup you also increased the performance a tiny fraction because of your grouping instead of my repeated filtering.

@tieskedh You're touching on a lot of code I wrote early on. This cleanup was overdue.

associate

- cool, didn't know about that 🙂

@tieskedh I've merged all PR's except this, where I think you made two mistakes: https://github.com/edvin/tornadofx/pull/432

until

excludes

to

@edvin I can't find your comments on this one, but untill is indeed excluding the last one and includes including. Some of the refactorings, which doesn't look right on first side, can be found by: 1. invert the if-statement 2. transform to range-check 3. invert the if-statement again.

fun <A,B> myClass<A>.exec(param:KClass<B>)

does anyOne know if I can change B in a reified param, without having to specify A?

fun <A, reified B> myClass<A>.exec()

needs to be called with two generics, which makes the function call ugly... two requirements: 1. It needs to be a extension function. 2. We need both types https://try.kotlinlang.org/#/UserProjects/i17k5bu7c48i0j6uhv211gbuth/5arob1v1h262kb1u0frdei15pn

@tieskedh That's wierd, here are my comments on the review:

@User uploaded a file:

you're right, first need to be !in and around second 0 until itemCount are brackets needed.

Great, let me know when you've committed a fix and I'll merge 🙂 Going to bed now though 🙂

@edvin changed and added reified types where possible

@tieskedh Thank you once again 🙂 Will go over and merge later today.

@edvin ok, I'm now experimenting in smartResize

@tieskedh Cool! We have an open ticket complaining about performance on smaller devices. There might be things we can do to improve the current design, or we might need to do a bigger refactoring to improve performance. Right now it works good for desktops, so I'm not prioritizing this myself, just thought I'd throw it out there, since you've proven yourself to be quite the wizard 🙂

I saw it. and thx 😉

@User shared a file: Untitled

@tieskedh commented on @tieskedh’s file https://kotlinlang.slack.com/files/U3QQLJNG3/F6X4JN77S/-.kt: Don't know if it's quicker, but I replaced the following code:

@tieskedh commented on @tieskedh’s file https://kotlinlang.slack.com/files/U3QQLJNG3/F6X842N0Z/-.kt: with this one

@User shared a file: Untitled

@edvin I'm trying to use custom font in my application This is where I put the font files and fontstyle.css https://cl.ly/2R3o3y0X0s1e this is my styles file

init {

        importStylesheet("/fontstyle.css")

        label and heading {
            padding = box(10.px)
            fontSize = 20.px
            fontWeight = FontWeight.BOLD
        }

        smallLabel {
            fontSize = 11.px
            fontWeight = FontWeight.SEMI_BOLD

        }

    }

This is my fontsyle.css

@font-face {
    font-family: 'Lato';
    src: url('fonts/Lato-Regular.ttf');
}

@tieskedh commented on @tieskedh’s file https://kotlinlang.slack.com/files/U3QQLJNG3/F6X842N0Z/-.kt: instead of changing one thing at a time, it takes all the same prefwidths and updates them equally