It will now respect the sizes you set for fontSize in different selectors.

I think it should be fine, changing it. Just scream if I messed up 🙂

Snapshot from the CounterView.fxml which is an example from tornadofx doc and sanity check compared to code from Carl that he shared with me with same results. So why does "#increment" show in red?

@teckeon It is red because you haven't told intellij what controller it should look in. You can configure the fx:controller attribute, but if you do that you also have to add the

hasControllerAttribute = true

paramter to the

fxml()

delegate in the View.

@edvin It is called out in fxml() and may have understood the tornadofx which is possible, thought that a controller was not needed and if needed thought tornadofx would have created one by default.

@edvin here is a snapshot

@teckeon Even if you have told TornadoFX where to find the View, IntelliJ - your IDE still doesn't know about this connection. Hence, it can't help you unless you also tell it, via the fx:controller attribute, what controller to use.

@edvin Ahhh.. okay.. thank you, sir!

@teckeon If you specify the controller, you also need to specify the

hasControllerAttribute

parameter like so :

override val root: BorderPane by fxml("/CounterPane.fxml", hasControllerAttribute = true)

I suggest skipping FXML altogether and going for builders though. FXML offers little to none value and just increases the boilerplate and forces you to deal with UI code in two different places. Just keep your View class free of business logic and deal with events and UI nodes in one place.

@edvin Will do. I do need to break away from Scene Builder 🙂

@teckeon Good call 🙂 You won't regret it, I promise 🙂

@edvin when i access the params View object in @pike 's code in an onDock, the values don't appear to be changing in inheritParamHolder. Calling this once works fine, but the next button press doesn't change the values

@edvin Here's the View. On the second call, "myval1" and "myval2" are the same values as the first call. I walked through the openModal() call and that params object is fine.

@teckeon I have mixed feelings about FXML. On the one hand, I saw graphic designers produce usable JavaFX code (still in use after 4 years) and perform a clean handoff to developers. Also, Scene Builder is great for prototyping. Just drag a few components on the screen and press Control+P. Works with complex nested screens too. The XML has been highly compatible through the years. However, the most recent versions of Scene Builder I worked with had a bunch of bugs: problems opening more than one instance, not being able to resize the window after launching, not being able to drag-and-drop from the hierarchy after a while. I sometimes use an older Oracle version. With TornadoFX, you'll hit a wall with FXML support that IMHO will make it unsuitable (TornadoFX + FXML, that is) for larger projects which is nesting. See https://github.com/edvin/tornadofx/issues/243. Any rich UI app is going to need nesting as a way to break apart its complex view code. So, I would stick to the app design of Views and Fragments and the Builder Pattern. There is something called the Layout Debugger which is handy when prototyping.

@carlw Good points indeed!

We could "easily" fix the nesting by creating our own loader, but I don't feel it's a good call to invest so heavily in FXML.

@carlw Will check that code later today.

@edvin I'm again busy with the ranges (removed old branch). I came across a potential bug in datagrid on line 214. I want to fix this, but I need a confirmation that it indeed is a bug. On this moment, it is (I think) not possible to get the latest item. Is this a bug?

Let me check!

Yeah, that last - 1 should be removed, or changed to range check for sure.

@tieskedh Please also add to CHANGELOG with the PRs 🙂

a lot of work with my reification 😉 I'll add this fix.

Thank you!

I can imagine:)

@edvin at the reification, do I need to add every change in the changelog, or can I just mention that there are lots of reified functions added?

@tieskedh That's enough. I added a single line about internal refactorings. We don't need to mention those specifically unless they alter functionality/api.

which is the case with reification

This is kind of random, but I was wondering if anyone has any thoughts/experience with Tooltips on series with 2,000 or more items... it works, but it takes 30 seconds to add them...

@jchildress I'd use a popup like the link below because you'll have more hooks than the tooltip. For example, you can popup an empty box immediately with a "Loading..." label while you gather the list contents. http://bekwam.blogspot.com/2015/11/a-popup-helper-in-javafx.html