@edvin what is the purpose of the params parameter in find() ?

@carlw To pass params onto the view you open.

@carlw I don't really like it, because it won't work "twice" for Views, only for Fragments. ViewModels are much better IMO.

@edvin , I made a mistake, which was catched by @Ruckus. Created new pull-request to fix it

@tieskedh Merged. @Ruckus has saved us more than once :))

I have a new question concerning the nativeInstaller in fxlauncher. I only use macOS and needed to create an installer for Windows and saw that this seem to be only creatable in the same OS that is running the gradle task. So I installed a Windows and compiled everything and got a few files. I think the exe is the same as the dmg and so I tried to execute it but always get a message that some C++ DLL is missing on my windows. Do I have to do something else to make this runnable?

@dr.fornax You need to install InnoSetup to create a native installer on Windows. All the requirements of javapackager still applies, since ultimately the executable is created by javapackager.

@dr.fornax The javapackager output during the

generateNativeInstaller

phase will hint to any issues with generating the installer.

Thank you. I have not seen any issues in the logs. Only when I tried it on the other computer I got the missing DLL error. I will then try again with InnoSetup. This was my fault 🙂

@dr.fornax Are you sure it was the actual installer you copied to that other machine? I suspect it was the "bootloader' if you will.

And one other quick question. When I create my UI. What is the recommended way to deal with components that are included several times. I wrote some wrapper function where I call a fieldset, vbox etc in it and simply thought I could now run the function and the filedset and vbox is added then, but I think there seem to be more magic to return it in some way. Hard when you start with Kotlin and TornadiFX at the same time frm scratch 😉

@edvin Probably it was the bootloader. It was an exe file with the same name as my project. But I will try to install InnoSetup first

@dr.fornax Yeah, it should output the installer in some subfolder, I don't remember the exact path, but it's documented in javapackager and possibly in some of my demo projects. Let me know if you can't find it.

@tieskedh I added a comment/review on PR 445

I will have a look. This might be morge complicated when I add this to my CIS since this runs on windows and I have to find a way to crosscompile the exe on windows…

sorry, runs on linux

I try this when I have access to the windows pc again

@edvin I can't see the comment

@edvin (make sure you submit your review or no one will see your comments)

can't believe params sparked such a discussion. For now I've switched to properties: find(class).properties["x"] = "y"

@pike edvin and I have been advocating for MVVM style apps but every FX developer i worked with does what you're trying to do when opening dialogs MVVM means that you're setting up some other accessible data structure (ViewModel) that both the setter and the guy on the other side of the modal can get to

yeah, I'm considering changing it to a view with just a ViewModel and hit the api before loading the view and set the ViewModel.

my problem is drawing charts from the viewmodel, I guess I could attach a listener to the observable list to trigger a chart creation

@pike MVVM might fit better because the chart, legend, axis, etc could draw off of the same ViewModel

they all do

it's just the drawing part, I have to iterate the data points and attach a listener node to each one for the hover effect

the layout is all set with a VM, then I draw two charts and stick them in. I suppose I can adjust my hoverchart

1 chart is the sum of the data - 1 element, the other chart is all the elements in a stack line

@User uploaded a file:

when you double click on one of the names in the box below, it swaps to a view of just their data