Channels
#tornadofx
- t
tieskedh
09/08/2017, 1:32 PMlook for example to SmartResize. It's big, because it's 2 times exactly the same code - t
tieskedh
09/08/2017, 1:33 PMI think implicit interfaces can help a lot here - e
edvin
09/08/2017, 1:33 PMYeah, for some internal stuff it could be great indeed 🙂 - e
edvin
09/08/2017, 1:33 PMWe could delegate manually for SmartResize though. - t
tieskedh
09/08/2017, 1:39 PMI tried, but treetablecolumn and tablecolumn doesn't extend and treetable and table doesn't extend either... i get the idea that java hates extending 😉 - t
tieskedh
09/08/2017, 1:39 PMit's of couse because they want to simulate multiple extensions - c
carlw
09/08/2017, 4:26 PM@tieskedh reminds me of duck typing - e
edvin
09/08/2017, 4:26 PMWhat I mean is that we could create a wrapper that holds either a TreeTable or a TableView, and forwards to the correct call. - e
edvin
09/08/2017, 4:27 PMIt's a grey area.. we might end up with the same actual amount of code, but the upside is that we could only write the actual logic in one place. - t
tieskedh
09/08/2017, 4:30 PMah, the adapter pattern - t
tieskedh
09/08/2017, 4:41 PM@edvin new PR, bigger than I expected... And horrible comparison from github... - e
edvin
09/08/2017, 4:42 PM@tieskedh Thank you so much once again 🙂 Sorry for the late merging, will get everything merged this weekend. - t
tieskedh
09/08/2017, 4:43 PMhaha, doesn't matter, better a good check than bad code in main - t
tieskedh
09/08/2017, 4:45 PM@edvin I will look to the adapter-pattern in SmartResize - e
edvin
09/08/2017, 4:46 PM@tieskedh Thank you! You got to decide if it's worth it after you've played with an adapter I guess. - t
tieskedh
09/08/2017, 4:46 PMI will push and you can reject😎 1 - g
guggulf
09/08/2017, 5:23 PMCould someone explain how the
function works? I'm trying to bind the rotation of a Node to the result of calculating the angle of a line between two pointsdoubleBinding() - g
guggulf
09/08/2017, 5:25 PMWhere the coordinates are allDoubleProperties - e
edvin
09/08/2017, 5:50 PM@guggulf The
callback creates a binding, it doesn't bind to the rotateProperty. The result of the doubleBinding however, can be bound to thedoubleBinding
if you desire.rotateProperty🎉 1 - e
edvin
09/08/2017, 5:51 PMIn your case, you probably wantrotateProperty().bind(doubleBinding(observable, dependencies, here) { calculateResultHere() }👍 1 - g
guggulf
09/08/2017, 6:18 PM@edvin Ah, thanks a bunch! - e
edvin
09/08/2017, 6:35 PM@guggulf My pleasure :) Did you get it to work like you wanted to? - g
guggulf
09/08/2017, 6:35 PM@edvin I sure did, thanks again. 🙂simple smile 1 - c
carlw
09/08/2017, 6:46 PM@guggulf You might find this interesting...It's a little JavaFX-y. I'm going to try out @edvin 's snippet - c
carlw
09/08/2017, 6:49 PM@guggulf If you want to skip the extra class, you can use @edvin 's technique with my formula - c
carlw
09/08/2017, 6:49 PM@User uploaded a file: DoubleBinding w/o Separate Class - g
guggulf
09/08/2017, 6:58 PM@carlw Thanks for the tips 🙂 - d
dr.fornax
09/08/2017, 7:27 PM@carlw, the code you sent me concerning the combobox works. THank oyu very much, this seems to be the solution - d
dr.fornax
09/08/2017, 7:28 PM@carlw The reason why I sent you the wrapper function was to decouple it a bit and to have one function that can be used for email, phone etc. I still think about the way how this is done👍 1