and maybe there is a flag already around that we can use for initialized like !hidden which is available after the binding

oo2

Okay, I switched back to check only the phone number and can verify this

@User uploaded a file: Untitled

When I start the app, I jave a PhoneNumber in my second contact and it is not dirty. The other contacts where I have no number are dirty. Evene when I click save (commit) it is still dirty

I try what you sent me

seems like it might be a timing thing and the problem is that the dirty mechanism works on changeevents

but the variable initialized need to be created my myself?

i think so unless we can find something else suitable. for example, the hidden flag of a Stage might be flipped to !hidden (shown) after the initialization of phoneNumberModels

Probably I have to set dirty to false after initializing the app

for now...it's something the framework should handle but if we get something working, i can create a better PR

Hm, but do you think this works? When I save, then I commit and it stays dirty when there is no entry in the list?

not sure yet...i'm trying to get a simpler example going

Thank you. I try to investigate it also a bit more

a questions: resizeColumnsToFitContent in nodes.kt has two implementations, is there a reason for, and if not, which has preference A remark: I think I found the bug in smartResize that makes it slow: I believe the instanceCheck in isPolicyInstalled for treeTable is wrong.

@tieskedh About caught exceptions: I think it's just a side effect of the copied code. A bug was probably fixed in one place, and I forgot to copy it to the other. That's one of the issues with the current approach. Very happy to hear about the bug you discovered! We have an issue about the performance, when we have merged your PR we can ask the guy to re-test his app to see if performance is increased.

@tieskedh

resizeColumnsToFitContent

has one implementation for TableView and one for TreeTableView?

yes, one with a try catch(which is silenced) and one without try/catch

@tieskedh I think we want the try/catch, but possibly with logging?

comment is // Silent for now, it is usually run multiple times

your call 😉

Let's leave it silent, I thnk performance is pri 1

@tieskedh Are you going to ammend some of the PR's or should I start review/merge now?

nope, you can review

OK, I'll start now. Thank you for all your hard work these past weeks.

I also need help to look at issues if you're up for it! We have 18 open issues right now. Not all of them needs to be resolved, but we have some that would be good to find a solution to.

Anybody else want to chime in on https://github.com/edvin/tornadofx/pull/450?

@edvin,I didn't dive into the framework yet, so I have to study the framework first

@tieskedh OK, I understand. Smart 🙂 hehe

I'm looking at the grid pane issue @edvin