I don't think it changes much the first time, but it changes when you use resize multiple times, because in the previous version, the resize always added new listeners

So if you resize your window, you'd probably see a big difference then.

git is slow...

PR

Reviewing now.

Just need to start a new 3D print first, back in a little bit.

ok

@tieskedh Wow thanks for all the great work you are doing lately. And sorry guys for being not to that active lately, I hope to be able to work on the `ViewBuilder`soon again 😉

@nimakro Don't worry, this has to be fun, not a chore. I've felt bad myself lately, but I realize that's just how it has to be, we can't always put in inhuman hours on the framework, we'd burn out 🙂

@tieskedh Looking at the PR now. This looks great. I've started on this work two times and gave up because it sucked. I think you've nailed it, not completely done yet though.

@edvin bug was no bug 😥

See ResizeTypeProperty in SmartResize

By both the tables SmartResize is added

where is property[SMART_RESIZE] set?

@tieskedh

contentWidhtField

is misspelled, will you update the PR before I merge?

It looks like a duplicate of SMART_RESIZE_INSTALLED

It should be removed I think.

I think the PR that introduced those consts added one too many, or maybe I always used two keys mistakenly

There were two, different types

before refactoring, smartresize is also only read. Does javaFX change the tornadofx.smartresize itself?

Something is wrong here. Nothing else changes this property.

BRB

i'm going to sleep. will beback tomorrow

Yeah, same here 🙂 We'll sort it tomorrow 🙂

Could it be that one of the last changes in the 1.7.11-SNAPSHOT broke the drawer? Since my last update I now have toggle buttons for the items and no individual items are shown, it behaves like a vbox. When I go back to 1.7.10 everything works again

The Learning RxJava with JavaFX guide has finally been updated to 2.x, and I also updated the TornadoFX examples.

@dr.fornax Checking!

@dr.fornax Yeah, it's broken. The DrawerTestApp shows the drawers, and expands them on click, but it doesn't close them when I click again. @tieskedh I suspect this is a result of your refactoring.

@edvin Thank you for your quick reproduction of the drawer bug