Channels
#tornadofx
- e
edvin
09/10/2017, 12:28 PM@tieskedh Yeah, I found that one bug, but it seems like he's struggling with something else. I can't reproduce his issue, so we'll have to wait for him to get back to us.👍🏻 1 - e
edvin
09/10/2017, 12:29 PM@tieskedh I found the issue with SMART_RESIZE vs SMART_RESIZE_INSTALLED. Pushing a fix soon. There seems to be other issues with your changes though, hang on. - t
tieskedh
09/10/2017, 12:30 PMhaha,I'm like an elephant in the porcelain cupboard *like a bull in a china shop😬 1 - e
edvin
09/10/2017, 12:33 PMHehe, a little chaos to clean up everything, but in the end it will be worth it. - e
edvin
09/10/2017, 12:33 PMtoTornadoFXColumn is failing with npe - t
tieskedh
09/10/2017, 12:34 PMnpe in kotlin? - t
tieskedh
09/10/2017, 12:35 PMwhih line of TornadoFXColumn? - e
edvin
09/10/2017, 12:36 PMjava.lang.IllegalArgumentException: Parameter specified as non-null is null: method tornadofx.adapters.TornadoFXColumnsKt.toTornadoFXColumn, parameter $receiver - e
edvin
09/10/2017, 12:36 PMDo a pull and try to run PojoTreeTableColumnsApp - e
edvin
09/10/2017, 12:39 PMThe functions are called by JavaFX with a callback parameter where column is null. I think I read somewhere that it does this as part of an init step. - e
edvin
09/10/2017, 12:43 PMI fixed it, on to the next bug: TornadoFXTable<S, T>.resizeColumnsToFitContent assumes the column is of type TreeTableColumn - e
edvin
09/10/2017, 12:44 PMHang on, committing a fix 🙂 - e
edvin
09/10/2017, 12:48 PMIn resizeColumns.forEach { resizer.invoke(skin, it, maxRows) }, you pass in the TornadoFXColumn instead of the actual JavaFX column type. We need to expose that from the wrapper. - t
tieskedh
09/10/2017, 12:50 PMyep, same as table. - t
tieskedh
09/10/2017, 12:50 PM(but it's already done there) - e
edvin
09/10/2017, 12:52 PMNo, you passed the wrapper, not the actual column. I added the column to the TornadoFXColumn class and passed that instead - t
tieskedh
09/10/2017, 12:52 PMon this moment I called it table, but should we rename it to something like nativeColumn/nativeTable? - e
edvin
09/10/2017, 12:53 PMMaybe, for clarity. I added the 'column' parameter here and pass that in doResize instead - t
tieskedh
09/10/2017, 12:53 PMyep, I already did something like that for table, maybe you can rename them both and do the next update - e
edvin
09/10/2017, 12:54 PMOK, hang on - e
edvin
09/10/2017, 12:55 PMNah, actually, it's fine. It's clear as it is, as long as we used the correct value 🙂 hehe👍🏻 1 - e
edvin
09/10/2017, 12:56 PMI think we might run into more similar issues, just small bug that are hard to catch while reviewing the code, but which is easy to fix and spot once you have a failing use case. - e
edvin
09/10/2017, 12:57 PMThis is one of the reasons I never did this cleanup. But I'm very happy that you took the time! - e
edvin
09/10/2017, 12:59 PMIt will be much more pleasant to evolve this code further now. - t
tieskedh
09/10/2017, 1:01 PMI think we could do more with the wrappers. I'm looking into it now. And than when the implicit interfaces are introduced, the wrappers can be refactored to those... - e
edvin
09/10/2017, 1:03 PMYeah, that's a good idea. All in all it will save us some code and make refactoring much more pleasant. - t
tieskedh
09/10/2017, 1:03 PMand more important: logic... - t
tieskedh
09/10/2017, 1:04 PMI don't like JavaFX didn't do this by themselves...