@edvin Or the other way around, because I believe you should not use bind(aProperty) but bind(a)? As I said I don't know a lot about the framework yet, but I believe it's build around the second way?

@edvin Alright I moved the functions I think we are ready for merge 😉

@tieskedh You should always bind towards the property, not the getter/setter.

@nimakro Sweet, merging 🙂

@edvin @tieskedh By the way I can confirm the bug if you bind towards the property you get a property in a property 😀

@edvin uploaded a file:

@edvin uploaded a file:

@nimakro Thanks! Need to figure out how to sort this, I will see if I get some time tonight.

@edvin Gosh this is pretty 😉

I might find some time to look at the bug after work 😉

@nimakro That would be fantastic! Let me know if I can help in any way. There might be more ways to attack this, one way would be to add overloaded functions that accept nullable properties. This will require some adaptation to the type parameters of the

bind

function I think.

@abhinay commented on @edvin’s file : @edvin Interesting choice of key placement. What made you to align backspace and enter at the center?

@abhinay It's much more convenient to use the stronger index finger to hit backspace and enter compared to using the pinky. Some people even move the whole hand just to use backspace and enter, which takes time and induces unnecessary strain on the shoulder. It's just faster and more convenient. Real easy to get used to as well.

You never leave the home row when using those keys on this layout.

I have never used a keyboard with this type of layout. It would be fun to order one 😉

@abhinay I'll let you know once I have them in stock :))

The biggest change for most people though is the ortholinear placement of the keys.

Other than that the keyboard looks pretty neat!

@edvin I think the nullable properties question is related to issue #389. It looks like before the issue you might not have been able to bind to something nullable.

@carlw Ah, thanks! That's it. So I messed up it seems.

@nimakro If you end up looking at it: https://github.com/edvin/tornadofx/issues/389

Yup right. There were a few comments on the linear placement of keys for a keyboard which tried to do the same. Let me see if I can find the name of the keyboard.

@abhinay Perhaps Planck? Also ErgoDox and TypeMatrix.

Haha, you know them all 😂

@abhinay He has them all 😉

⌨️

@edvin do you want to change the body of the bindField method to evaluate the type of the bind() arg and then check if it's a JavaFX Property? If so, then return the property. Otherwise, wrap?

@carlw That might be the easiest way to deal with this actually. I didn't think of that, I only thought about type signatures 🙂

sometimes my java-oriented hangups are useful @edvin

@carlw Hehe, absolutely!