Indeed, but at the same time, we've known for a while there would need to be some changes to allow the custom bases (for things like modena, material, etc.). If he comes up with a better change (or a good way to rewrite the whole thing), and it would make that easier, that would be pretty awesome.

Absolutely! Good that somebody is looking under the hood.

I've started removing pages from the Wiki. I really need help identifying what information is already covered in the guide and so can be removed from the Wiki. When that's done I'll copy the remaining pages over to the guide and remove the Wiki completely.

Let's try to finish any outstanding issue that has to do with stability and improvements, then start working on a JDK9 branch. I have a pretty good idea of how to do it by now, and I know of only one showstopper that will need a workaround.

@renatoathaydes That you very much for PR 482 🙂 Looking through it now. Wow, that ErrorHandler really needed some love. I'd still like to improve the UI part of the handler, as it's pretty gnarly and not using TornadoFX's own best practices, but it has been around since the beginning, before many of the current concepts were available.

@tieskedh In https://github.com/edvin/tornadofx/pull/474/, you're using

?: run { someCode() }

in several places. It seems wasteful to create a function instance and executing it instead of just writing inline code. Is it really worth it to avoid the traditional approach of

if/else

?

any news/rumors at JavaOne about future JavaFX developments?

@horse_badorties Not really, and I guess the general consensus is that introducing Jigsaw has been an enormous undertaking, and that we'll hopefully see more actual improvements coming out from here on in. Now that we're getting 6m release cycles, it's going to be much more rewarding working on new functionality as well.

thanks

@tieskedh I played a little with the code and I agree with your decision. Merged as is. Thanks once again for all your hard work. Reviewing the last one now.

I'm putting up the KDocs for TornadoFX on the web site. This will make it glaringly obvious that we're missing a lot of code docs. If you know how a function works, PRs are most welcome. It doesn't have to be extravagant, just a short comment about what a certain function does 🙂

@edvin, thanks for the KDocs. I generated them locally so I could get a better overview of what was available, but having them online (automatically updated?) is really helpful as I don't want to have to download and build just to get the docs.

@melston Sweet! I'll make sure they are updated once a day, together with the snapshot push. Right now I'm having issues building them though, it's just hanging for me. Did you run mvn site, or just dokka directly?

Huh... It's not hanging, it's just incredibly slow it seems.

@edvin, I think I imported into IntelliJ and ran it from there (though I don't really remember, now). I don't use mvn so that wasn't really an option for me.

OK 🙂 I'll publish the URL soon.

I see now why I didn't publish it before. It's pretty naked.

It might be naked but it was pretty easy to, for example, get a list of the extensions for TreeTableView (which I really needed).

Does that look like the one you generated @melston?

@edvin, it looks identical.

Perfect! KDocs are now pushed daily to this URL.

https://tornadofx.io/ is updated with new logo and link to KDocs 🙂

hey guys, I ran into a bit of a problem

object GameOptions {
    var paused by property(true)

    fun pausedProperty() = getProperty(GameOptions::paused)
}

does not compile since properties in objects are KMutableProperty0, they don't take class instance as the argument

is that known?

@cypher121 Never seen that use case 🙂 The

object

makes sure

getProperty

doesn't match

Any

. But do you really need/want this syntax? I would really recommend the new property syntax instead. Much more transparent, and also faster.

@edvin uploaded a file: Untitled

Unless you have a good reason for exposing the property as an actual function, that is.

not really, just kept it in line with how it's done in JFX

@cypher121 We've come to the conclusion that it doesn't add any value to expose the property as a function. Kotlin still provides encapsulation without breaking your code if you need to add that later, so my recommendation is just to go with the example I posted above 🙂 This should also be the default code generation format for the plugin now.