@edvin In IntelliJ, a remove the source tag on the parent's src/main so that it doesn't compile in that place and throw up warnings. the -jdk8 module is set to use JDK 8 and -jdk9 is set to use JDK 9

@carlw Good start! An issue we need to address is how to deal with duplicate files. Once a file differs, we'd have to either maintain two almost identical files. A "merge/glue strategy" would only work if IntelliJ supported it natively I think.

@edvin What do you think about breaking the Kotlin files up into common and jdk-specific versions? For example, Component.kt + Component-jdk8.kt + Component jdk9.kt

This would only be done for files that have jdk-specific code

And at some point in the future (6 mos, 1 year), you may decide to limit new features to the jdk9 versions. That way, if there is something requiring the now-open APIs, you don't have to try and back port it to the com.sun classes of JDK 8

Yeah, we need some kind of approach like this, without making stuff ugly, and while keeping it easy for developers to contribute. That's another issue I'm thinking about, if the setup becomes a mess, nobody is going to want to contribute anymore.

I'm waiting for Kotlin 1.1.60, I'm not going to do anything more on the jdk9 branch before that. Will think about this in the meantime. Thanks for all the input, Carl, very helpful.

You might have hit the spot with your suggestion, will for sure try it out.

When I get a chance, I'll put a blog up on the second approach (modules rather than profiles) because it interfered less with IntelliJ operation. With the profile approach, I had to go in and reset several IntelliJ settings after toggling the profile between JDK8 and 9.

You can also use a Git branch with this to demo how it looks

@edvin I am opening a fragment popup from a tabbed view. I want to close the tabbedview if user clicks on OK button from the popup.

@aayush You mean you want to close a specific tab? You should be able to just close that tab from the OK handler.

can i close that tab from the popup's button? What should I write inside the action of OK button in the popup?

@aayush Can you show me the code you have now?

ok

Looking at the API for Tab https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Tab.html, and TabPane https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/TabPane.html, it looks like you would need to obtain a reference to the

TabPane

and the

Tab

and call something like

tabPane.getTabs().remove(tab)

If those references aren't available in your popup fragment handler, you could have your fragment fire an event on the EventBus https://edvin.gitbooks.io/tornadofx-guide/part2/EventBus.html in the OK action, and then subscribe your View to listen for it

@aayush uploaded a file: Untitled

I wasn't around when the answer was given, but is it to late to migrate our nullable lambda's to empty lambda's? https://stackoverflow.com/questions/38784939/null-or-empty-lambda-as-default-value

@tieskedh I'm not sure it brings much value, and there is a semantic difference between an empty lambda and a null lambda. We can't detect if the user passed a value or if the lambda we're dealing with simply does nothing, so that might be problematic in some cases.

@edvin the advantage is that the code will be a lot cleaner, because you can always execute the lambda. This means the lambda can for example be given to an apply, and other than that, y you know the functions are always doing the same. I haven't found anything where you should not execute another statement where the lambda is null yet. When they will arise (which I doubt) then we can use a companion object for the default lambda and checking on that object

Are there any good ways to launch a global command from key events? Currently, I’m using the JNativeHook library, then using Platform.runLater{} to open a window, but, when I close it and the app, the process won’t die

@aayush Here is one solution, firing events to close the tab. This whole sample is too overengineered though, but it shows how to do it:

@edvin uploaded a file: Close tab using event

One thing you can do is to get rid of the whole GlobalExitPopup and just do this instead:

@edvin uploaded a file: Untitled

@tieskedh Then I think it should be safe to switch to empty lambda 🙂

The most basic example

fun A.test(a: (A.() ->Unit)? =null) = apply{a?.invoke(this)}

Would become

fun A.test(a: (A.()->Unit ={}) = apply(a)

@tieskedh You would notice while refactoring anyways, so go for it if you have the time!

It would as you say clean up a lot of code 🙂