@pike I would think something else is causing it. Can you try with a minimal app?

@jchildress Must be irritating for Gluon. And totally unnecessary as Carl pointed out. Almost comical that they chose that name IMO.

@pike I tested a minimal app, it works as expected. You can open the modal, then close it, then close the main window and the app exits as it should. You must be doing something else to keep it alive 🙂

@edvin uploaded a file: Minimal app that exits as it should when last window is closed :)

@edvin no clue --- I use the event bus to open a modal when the api call starts, then close it when the api call ends. but now that I've added that, the application doesn't want to exit nicely. I've had this problem before with just java/fx too (not with the modal). I don't have anything anywhere that spawns threads or background work

I was just thinking that it would be nice to be able to supply an inline stylesheet not just an inline style. This would allow for customizing sub components using selectors. For example, adding a local stylesheet to a tableview would allow you to configure the table cells for just that tableview. That's much harder to do using inline styles, since you'd have to target the correct component, which is not always easily available.

@Ruckus Would that make sense, or should I still blame jet lag? 🙂

I added an implementation and tried it, but I don't know how useful it will be, since you need to import the Stylesheet cssclasses, or specify them by class name. That could be confusing, since we have cssclasses with the same names as builders.

That could be very useful, especially for custom controls

You can do a fancy import though:

@edvin uploaded a file: Untitled

@Ruckus OK, I'll add it and do a screencast this weekend to show how it would work, and talk about the pitfalls that comes with that approach.

This is the implementation:

Sounds good. Are you just setting it as a user agent stylesheet for the control?

@edvin uploaded a file: Untitled

@Ruckus I'm adding it as a stylesheet to the stylesheet list of the Parent.

Ah, I see

Interesting

That won't affect the scene, will it?

I don't believe so, but I couldn't say for sure.

I can run a few tests with some plain CSS

Checking with a simple test case now 🙂

I added two forms, the first sets a custom stylesheet and I verified that it only affected the first form 🙂 So far so good!

Nice 🙂

I've been thinking about this some times when people ask how to style for example a table column.

I think this might work well, but I think we should make it a best practice to add an import alias to avoid confusion with builders.

The other pitfall is that if you're making a stylesheet inside of a Node you could end up hitting properties of the Node instead of selectors in the stylesheet, like builders. But this pitfall applies to the inline

style

builder as well, so that's not something new.

I've committed the feature if you want to check it out 🙂

Indeed, that's a problem I couldn't figure out a solution to. Not even the DSL annotation could help there.

Awesome