https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    10/23/2017, 6:09 PM
    It's a simple solution that doesn't open up the API more than needed to solve #507. Then we can allow further configuration of the 
    ThreadFactory
    later if needed.
  • e

    edvin

    10/23/2017, 6:11 PM
    I wonder if maybe it should even be true by default. What do you guys think?
  • c

    carlw

    10/23/2017, 6:31 PM
    Depends what you think about safety. If the Thread still has some work to do -- it's a worker thread saving a file versus something like an http listener -- then Platform.exit() is protected in the case of the non-daemon thread.
  • c

    carlw

    10/23/2017, 6:32 PM
    Maybe this is some kind of peer-to-peer thing?
  • c

    carlw

    10/23/2017, 6:33 PM
    You can always call System.exit() to abort immediately
  • e

    edvin

    10/23/2017, 6:58 PM
    @carlw That's a good point. It's probably safer to leave it as it is. Now there is a way to change it at least.
  • c

    carlw

    10/23/2017, 7:27 PM
    i put a note in the github issue @edvin. the daemon parameter seems fine, but I'd make the safer option (non-daemon) the default
  • e

    edvin

    10/23/2017, 8:44 PM
    @carlw Absolutely, thank you!
  • p

    pike

    10/24/2017, 12:54 AM
    How do you add an array in the jsonbuilder? in the toJson()
  • p

    pike

    10/24/2017, 2:46 AM
    Copy code
    val listArray = Json.createArrayBuilder()
            listData.forEach {
                listArray.add(it.toJSON())
            }
            add("targetGoals", listArray)
  • e

    edvin

    10/24/2017, 7:16 AM
    @pike Did you answer your own question satisfactory or is something unclear? I would recommend using JsonModel, since you can automatically convert an iterable of JsonModel to a JsonArray and vice versa.
  • e

    edvin

    10/24/2017, 7:17 AM
    @carlw The guys added a very nice solution to the daemonic issue 🙂 I think we're all set! You can now control thread characteristics on a per call basis (runAsync) and the threads are kept in separate pools.
  • p

    pike

    10/24/2017, 7:18 AM
    @edvin really?!?! I tried but I got an empty set back.
  • p

    pike

    10/24/2017, 7:18 AM
    it's a JsonModel
  • p

    pike

    10/24/2017, 7:20 AM
    or rather an array of JsonModels
  • e

    edvin

    10/24/2017, 7:29 AM
    @pike Show me your complete code including models 🙂
  • p

    pike

    10/24/2017, 7:29 AM
    later? 🙂
  • p

    pike

    10/24/2017, 7:30 AM
    I feel I'm forcing a lot of code lately, I don't have a good feel for json to java... I'm too used to POJO converters I suppose
  • e

    edvin

    10/24/2017, 7:32 AM
    @pike It should be pretty seamless when done right. We'll figure it out 🙂
  • p

    pike

    10/24/2017, 7:32 AM
    yeah, that's how I've been letting the code take me... if it feels forced, I have to rewrite 😛
  • p

    pike

    10/24/2017, 7:33 AM
    kind of a pythonic approach I suppose, but if the shoe fits
  • p

    pike

    10/24/2017, 7:34 AM
    it's important though to have clear, simple and easy to follow code.
  • p

    pike

    10/24/2017, 7:34 AM
    I hate explaining to underlings "Because .... "
    😂 1
  • e

    edvin

    10/24/2017, 9:00 AM
    Now you can register shutdown tasks as well 🙂 https://github.com/edvin/tornadofx/pull/510
    🙂 1
  • z

    zealous

    10/24/2017, 10:10 AM
    While working on a TornadoFX application prototype which uses Reactive Extensions I'd like to 'route' events from the SourceView to the TargetView. Currently I use a Controller which exposes a Property which is update via a subscription in the SourceView. I have some doubts about this approach and would like to learn about a idiomatic solution using TFX and RX.
    Copy code
    class SourceView : View() {

    val signalController: SignalsController by inject()

    add(JFXToggleButton().apply {
        selectedProperty().toObservableChanges().subscribe { signalController.sourceToSignalProperty.value = selectedProperty().value; }
    })

}

class TargetView : View() {

    val signalController: SignalsController by inject()

    Observable.combineLatest(signalController.searchFieldProperty.toObservableChanges().startWith(Change<String>("", "")),
    signalController.protocolPredicateProperty.toObservableChanges().startWith(Change<List<(SignalProperty) -> Boolean>>(listOf(), listOf())),

    signalController.sourceToSignalProperty.toObservableChanges().startWith(Change(true, true)),

    Function3 { _: Change<String>, _: Change<List<(SignalProperty) -> Boolean>>, enable: Change<Boolean> -> { enable.newVal } })
    .forEach { f ->
        if (f()) doSomeFancyStuff()
    }
}

class SignalsController : Controller() {

    val sourceToSignalProperty = SimpleBooleanProperty(true)
    var sourceToSignal by sourceToSignalProperty
}
  • e

    edvin

    10/24/2017, 11:04 AM
    I've never used RX myself, but hopefully someone else here can help you out 🙂
    metal 1
  • c

    carlw

    10/24/2017, 11:10 AM
    @edvin It's probably better to use Application.stop() or something on the FX side instead of the JVM shutdown handlers so that you get feedback to the user. These hooks will just hold up the exiting of the app.
  • c

    carlw

    10/24/2017, 11:10 AM
    @edvin Maybe even something on the onHide could be added to encourage a JavaFX tie-in?
  • a

    aayush

    10/24/2017, 11:11 AM
    @edvin As you suggested I used 
    Fragment
    instead of 
    View
    for my 
    Tab
    UI. I have some 
    Labels, Textfields
    & a 
    list
    which is binded to a 
    tableview
    . When I use 
    Fragment
    the list contains previous data which was before closing the tab but the labels and textfields get refreshed. When I use 
    View
    the vice-versa happens. I want to clear all the variables and views when I close the tab. How to do this?
  • e

    edvin

    10/24/2017, 11:26 AM
    @aayush I'd have to see the code, but bear in mind that even if you create new ui components, you're probably still binding them to existing data.
1...146614671468...2007Latest