kotlinlang #tornadofx

bindChildren(controller.devices) { device ->
                            titledpane(
                                    title = "Device: " + device.name,
                                    collapsible = true,
                                    node = device.getDisplay().getBoardView()
                            )
                        }

altavir

11/14/2017, 1:12 PM

The problem is that when I call

setAll

on this

devices

list, appropriate node is added not once, but twice and I get exception about adding the same node twice.

edvin

11/14/2017, 1:16 PM

@altavir Can you post the complete stack? Are you sure you're not returning the same node for

device.displ.boardView

for multiple instances?

altavir

11/14/2017, 1:18 PM

I've localized problem to

ListConversionListener

, the line

list.addAll(change.from, change.addedSubList.map(converter))

is being called multiple times. I am using setAll on list of size 1 so there should be exactly one element in the response. An I've checked in debugger that my method is called once.

altavir

11/14/2017, 1:18 PM

Copy code

java.lang.IllegalArgumentException: Children: duplicate children added: parent = VBox@5ee2d167
	at javafx.scene.Parent$2.onProposedChange(Parent.java:454)
	at com.sun.javafx.collections.VetoableListDecorator.addAll(VetoableListDecorator.java:249)
	at tornadofx.ListConversionListener.onChanged(Collections.kt:231)
	at com.sun.javafx.collections.ListListenerHelper$SingleChange.fireValueChangedEvent(ListListenerHelper.java:164)
	at com.sun.javafx.collections.ListListenerHelper.fireValueChangedEvent(ListListenerHelper.java:73)
	at javafx.collections.ObservableListBase.fireChange(ObservableListBase.java:233)
	at javafx.collections.ListChangeBuilder.commit(ListChangeBuilder.java:482)
	at javafx.collections.ListChangeBuilder.endChange(ListChangeBuilder.java:541)
	at javafx.collections.ObservableListBase.endChange(ObservableListBase.java:205)
	at javafx.collections.ModifiableObservableListBase.setAll(ModifiableObservableListBase.java:90)
	at inr.numass.control.BoardController$$special$$inlined$apply$lambda$2.invoke(BoardController.kt:67)

altavir

11/14/2017, 1:19 PM

last line is a call from my code

thomasnield

11/14/2017, 1:28 PM

It looks like Gerrit Grunwald is working hard on the JavaFX scientific charting library. This stuff looks amazing.

altavir

11/14/2017, 1:30 PM

It is something completely strange, list size inside change somehow increases when

change.wasAdded()

is called. Maybe something is wrong with gradle cache...

edvin

11/14/2017, 1:36 PM

@altavir Are you able to make a small contained sample app?

altavir

11/14/2017, 1:39 PM

Not sure. For now I have a very strange behavior, which looks like a compilation bug. I will try to check it further with debugger.

edvin

11/14/2017, 1:57 PM

@altavir If you just updated your TornadoFX version dependency, make sure you do Build -> Recompile project.

edvin

11/14/2017, 1:57 PM

@thomasnield Cool! I haven't had time to check it lately, but I saw some pictures. Looks fantastic!

altavir

11/14/2017, 2:02 PM

Some time ago I was searching for a chart library on top of JavaFX charts, but I've encountered two problems: 1) Not interactive out of the box 2) Can't combine lines and points on a single chart without a lot of headache. I hope it will be solved. JFreeChart is a good library, but it is very old.

altavir

11/14/2017, 2:37 PM

I've cleared the cache and tried a bit older version of tornadofx. The problem persists. For now I just created an implementation without

buildChildren

. It works fine. The problem still looks like a compiler bug to me, but I can't understand, what happens. Maybe you should see if similar problem would arise somewhere else.

edvin

11/14/2017, 4:51 PM

@altavir Our best bet is a small app that showcases the issue. Then I'm sure we'll figure it out quickly!