@wineluis If you look at the documentation for the

tableRow

property you'll see: " /** * The TableRow that this TableCell currently finds itself placed within. * The TableRow may be null early in the TableCell lifecycle, in the period * between the TableCell being instantiated and being set into an owner * TableRow. */ "

Ie, it can be null. Do

tableRow?.hasClass

and

tableRow?.addClass

By the way, it's safe to call removeClass even if the class isn't present, so you can simplify your logic.

just debugging

i hoped to use toggleclass

futile anyway if i cant use makeeditable

If I get time I'll show you how to combine the two later today 🙂

thanks

i keep trying too

@wineluis Check out my todomvc sample app: https://github.com/edvin/todomvc/

Spesifically the TodoItemFragment: https://github.com/edvin/todomvc/blob/master/src/main/kotlin/todomvcfx/tornadofx/views/TodoItemFragment.kt

You configure a fragment instead of calling cellFormat with

cellFragment(YourFragment::class

Inside the fragment you would wrap the itemProperty around an ItemViewModel and then add both a textfield and a label to the fragment. You can configure which to show based on the editingProperty.

Hmm.. maybe this is too involved for what you're trying to do.

Maybe just setting a rowFactory?

@edvin uploaded a file: Untitled

what would the equivalent to this be: cellFragment(TodoItemFragment::class)?

column("BING bong BOng", TodoItemFragment::class)

(in tableview {} instead of listview)

i think this snippet doesnt work

@gtnarg Thanks for sorting #550 🙂

@wineluis The item parameter must be nullable (

item: S?

), I've updated the code example above.

Not sure what you mean by equivalent.

cellFragment

accepts a fragment class while the second parameter to

column

expects a property reference.

I want to know how I put the fragment into the tableview, as I would with column(). cellFragment(MappingRelevantCell::class) seems to be available only for listviews

@sleonidy Great PR for OSGi 🙂 I think it was important to expose the

addChildInterceptor

function.

@wineluis You're right, it seems we haven't added it for TableView yet. I'll get to it 🙂 But for your use case I think it's easier to just go with the rowFactory approach.

@edvin I think we need to add unit testing for OSGi component

@sleonidy By faking the OSGi environment or actually starting an OSGi container?

@edvin yep it works, thanks a lot 🙂. I think using a fragment is a nice approach, so I tried