kotlinlang #tornadofx

@kastork Does it also fail if you run the test from inside of IDEA? If so, set a breakpoint in the addChildInterceptor function and see where it's being called from perhaps?

kastork

11/29/2017, 8:41 PM

@edvin, yes, but that's because the test arguments are entered backwards. In truth the expectation is 2 and the actual outcome is 4. You said it right, but the test report has it backwards

kastork

11/29/2017, 8:42 PM

I'll try it in IDEA

kastork

11/29/2017, 8:51 PM

@edvin The test is passing if I run it from IDEA (this is just by clicking the green arrow in the margin of the test file). But

mvn install

generates the failure

edvin

11/29/2017, 8:52 PM

@kastork Can you remove

/src/main/test/resources/META-INF/services/tornadofx.ChildInterceptor

and rerun? Does it say 2 or 0 interceptors then?

kastork

11/29/2017, 8:53 PM

when running directly from the test file, it generates two calls to

addChildInterceptor

(this is before removing the META-INF file)

kastork

11/29/2017, 8:56 PM

After removing the META-INF file...

kastork

11/29/2017, 8:57 PM

mvn test

generates two failures: "Expected 0, but was 1" and "Expected 0 but was 1" (but remember the nature of the test arguments is backwards. It means to say Expected 2 but was 0.

kastork

11/29/2017, 8:58 PM

Copy code

onlyOneInterceptorShouldWork(tornadofx.tests.ChildInterceptorTest)  Time elapsed: 0.004 sec  <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:88)

kastork

11/29/2017, 8:58 PM

and

kastork

11/29/2017, 8:58 PM

Copy code

interceptorsLoaded(tornadofx.tests.ChildInterceptorTest)  Time elapsed: 0 sec  <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)

edvin

11/29/2017, 8:59 PM

So even without the service file, those functions are called. Can you set a break point and look at the call stack?

kastork

11/29/2017, 8:59 PM

Running from the UI again... with the removed META-INF....

kastork

11/29/2017, 9:00 PM

@kastork uploaded a file: Untitled

-.sh

kastork

11/29/2017, 9:01 PM

@edvin are the stack traces enough?

edvin

11/29/2017, 9:01 PM

@kastork Let's try!

user

11/29/2017, 9:02 PM

@kastork commented on @kastork’s file https://kotlinlang.slack.com/files/U4Z1U6LJK/F887ZR0BY/-.sh: This is running the test alone from the IDEA gutter menu

-.sh

edvin

11/29/2017, 9:02 PM

I didn't write this myself, but I couldn't see it beeing called from any other place, so I'm curious to figure this out 🙂

edvin

11/29/2017, 9:02 PM

We need the call stack or a stack trace when the addChildInterceptor is called, not from when the test fails.

kastork

11/29/2017, 9:03 PM

@kastork uploaded a file: stack traces when running `mvn test`

stack_traces_when_running__mvn_test_.sh

kastork

11/29/2017, 9:03 PM

ok, stand by

kastork

11/29/2017, 9:08 PM

ok, I've restored the META-INF file. Running from the GUI with a breakpoint in

addChildInterceptor

I get the call twice with the same stack trace and the tests pass. The call comes from

App#init

line 72 to

App#importChildInterceptors()

line 77 to

FX.addChildInterceptors

edvin

11/29/2017, 9:12 PM

So it's actually finding instances of the

ChildInterceptor

service even when the file is not present??

edvin

11/29/2017, 9:13 PM

I'll try to get a Mac set up tomorrow and look at it. I'm making a little UI app tonight 🙂

kastork

11/29/2017, 9:16 PM

Trying to get breakpoints to work when running the maven target

edvin

11/29/2017, 9:32 PM

Ah, that might be hard. Probably easier to add some code.

kastork

11/29/2017, 9:33 PM

my conclusion as well

kastork

11/29/2017, 9:34 PM

Copy code

fun addChildInterceptor(interceptor: ChildInterceptor) {

			try {
				childInterceptors.add(interceptor)
				throw Exception()
			} catch (ex: Exception) {
				println(ex.stackTrace)
			}
		}

edvin

11/29/2017, 9:39 PM

That should do it, but it's actually possible to get a stack trace with

Thread.currentThread().getStackTrace()

as well 🙂

kastork

11/29/2017, 9:43 PM

@kastork uploaded a file: Untitled

-.sh