Channels
#tornadofx
- a
amanda.hinchman-dominguez
11/30/2017, 8:04 PMthis is really cool! - a
amanda.hinchman-dominguez
11/30/2017, 8:05 PMoh wow, thank you SO much. Always looking to refactor. Some of these things come from the documentation, like setOnAction and with(root) - e
edvin
11/30/2017, 8:06 PM@amanda.hinchman-dominguez Thanks, I will start removing those from the guide 🙂 - e
edvin
11/30/2017, 8:07 PM@amanda.hinchman-dominguez I also see from a thread dump you committed that you're running a very old version of Java 8 on your Mac. This is bound to cause issues because that version contains a lot of bugs that was solved later on 🙂 - e
edvin
11/30/2017, 8:07 PMI'll try to run your app now. - a
amanda.hinchman-dominguez
11/30/2017, 8:08 PMoh! I didn't realize. I'll be sure to update that tonight - e
edvin
11/30/2017, 8:08 PMOh no, your login screen uses gridpane! Hehe 🙂 - a
amanda.hinchman-dominguez
11/30/2017, 8:09 PMand awesome! wait, are you serious? That whole login section came from your tornadofx samples. It was great to start with - a
amanda.hinchman-dominguez
11/30/2017, 8:09 PMI referred to both documentation and your tornadoFX samples and kitchensink heavily. I will note that both samples and kitchensink both have deprecated references - a
amanda.hinchman-dominguez
11/30/2017, 8:11 PMI can start logging what I see is old as I use them for reference - a
amanda.hinchman-dominguez
11/30/2017, 8:11 PM*in the github issues - e
edvin
11/30/2017, 8:11 PMI really need to update the guide. Hang on, let me change that login screen so you see how it should look now 🙂 - e
edvin
11/30/2017, 8:16 PMI've refactored it, but I think you have some CSS that messes with the form, hang on. - e
edvin
11/30/2017, 8:16 PMAh, this: - e
edvin
11/30/2017, 8:16 PMform { s(label) { textFill = Color.WHITE } } - e
edvin
11/30/2017, 8:17 PMOh, and also outdated syntax 🙂 - e
edvin
11/30/2017, 8:17 PMform { label { textFill = Color.WHITE } } - e
edvin
11/30/2017, 8:17 PMIf that's what you want. 🙂 - e
edvin
11/30/2017, 8:17 PM@edvin uploaded a file:image.png▾
- e
edvin
11/30/2017, 8:18 PM@edvin uploaded a file: Login screen refactored - e
edvin
11/30/2017, 8:18 PMOups, error here, hang on. - e
edvin
11/30/2017, 8:19 PMIt was "deprecated" shortly after it was added really. This was "never" the way to go, unless you're mentioning multiple selectors in one go. - e
edvin
11/30/2017, 8:20 PMI fixed the mistake in the code listing above. Now you can also remove
inloginScreen.username.requestFocus()
, because that field will get focus whenever the view is shown again. Notice also that I don't create variables to the input fields, but for properties instead.LoginController - e
edvin
11/30/2017, 8:21 PM(I didn't refactor or even look at
btw, it's probably good :)shakeStage - a
amanda.hinchman-dominguez
11/30/2017, 8:22 PMdoes requestFocus() programmatically refocus the app? - a
amanda.hinchman-dominguez
11/30/2017, 8:22 PMbecause that could be what I need to be able to refresh my grid with new data - f
favetelinguis
11/30/2017, 8:22 PMIm trying to do something like this where user is a ViewModel `enableWhen(user.token.value.isBlank().observable())`` , not really sure i understand bindings, could someone give som pointers on how to run a string function on a string property and turn it into a boolean property? - e
edvin
11/30/2017, 8:22 PM@amanda.hinchman-dominguez No,
is only available on the Node, I'm calling it on the textfield here.requestFocus - e
edvin
11/30/2017, 8:23 PM@favetelinguis
returns an observable boolean. What you're doing is fetching the Boolean value and turning it into an observable. That observable will never update.user.token.isBlank() - e
edvin
11/30/2017, 8:24 PMSo
is all you need 🙂enableWhen(user.token.isBlank())