@edvin what do you think about an ItemViewModel for the instrument selection carousel?

@ron If you remember, all of the builder functions are extending

EventTarget

, because there is no common super type for all JavaFX "constructs". Not even

Node

is a common super type. However, since almost everything in JavaFX extends

EventTarget

it's possible to call some extension functions on parents where it just doesn't make sense. Are you saying that you get this error if you call

runAsyncWithProgress

on an HBox? I wouldn't think that would fail, and it should work for sure.

@carlw That's probably a given 🙂 I think that it will be important to think of @javafxpert's app as a reimplementation, not just a conversion though, so that it will be written in an idiomatic way. That will ensure the ability to leverage as many framework constructs as possible (as long as they make sense of course)

@javafxpert It might be easiest to go from your program -> Kotlin/JavaFX -> TornadoFX. I see you’re using IntelliJ, so the IDE might automatically convert a lot of your program to Kotlin for you. From there, the refactor to TornadoFX would be very easy and I think a lot like the days of JavaFX script or visage. You’ll create an App / View pair and use Type Safe builders to build you the UI (ex “region{}“).

I don't recommend letting IDEA convert any of the code. You'll end up with a mess.

@edvin that’s why i’m suggesting an ItemViewModel. Maybe we can revisit the “tornadofx for javafx developers” series during the conversion?

The code IDEA generates is almost never what you want, at least not for a whole class at a time. And it will most certainly not end up being an idiomatic TornadoFX App.

depends on the level. throwing some of the model stuff into kotlin shouldn’t be too bad

but once it’s kotlin-ified, you can pick off the idiomatic stuff one-by-one

@carlw Even models are much nicer in the idomatic way. Try to convert a class with properties, functions to expose the properties, getters and setters and compare that to the idiomatic way of creating properties in TornadoFX. That's a world of difference.

not that many LOC even in Java

I'm more concerned about the content of those LOC's 🙂 hehe

Let me take a single example from James's app and I'll show you what I mean.

i don’t think the conversion is that bad for starting out. i just chucked a few snippets in the clipboard and it seemed to covert ok. for loops, logic, etc

here’s my example…

for (idx in 0.._numStrings - 1) {

@edvin uploaded a file: Small snippet from the Java version

Now let's let IDEA convert it:

for (int idx = 0; idx < _numStrings; idx++) {

(BTW your snippet was the first one I converted)

@edvin uploaded a file: Straight up conversion by IDEA

The way to do this in TornadoFX is:

@edvin uploaded a file: The TornadoFX way

no argument that’s better

@javafxpert Even if you start out with straight up conversion first, this point is very important to keep in mind. It will make a huge impact on the end result 🙂

Thanks @edvin and @carlw

I’ll most likely have questions when I tackle this (when my Surface Book 2 arrives this week)

@javafxpert We'll be here :))

Thanks!

I downloaded and ran the app now. It starts, then shows the carousel for second, then it disappears. I don't understand how to interface with the app 🙂