kotlinlang #tornadofx

its not so much a challenge but if you have not seen the screencast it will make it hard to gleen from the guide how to do it. Also in the screencast where the updateMessage, updateProgress comes from are vague (at least to me)

ron

12/10/2017, 12:42 PM

I was actually thinking of making it have a method as argument

edvin

12/10/2017, 12:42 PM

I think you might be better off not using the progress in the task, especially since we're gearing up to use coroutines.

edvin

12/10/2017, 12:43 PM

I changed your example to add a progress bar:

edvin

12/10/2017, 12:43 PM

@edvin uploaded a file: Untitled

-.kt

edvin

12/10/2017, 12:43 PM

Basically, update some shared property instead.

edvin

12/10/2017, 12:47 PM

Or use the

TaskStatus

helper:

edvin

12/10/2017, 12:47 PM

@edvin uploaded a file: Untitled

-.kt

edvin

12/10/2017, 12:47 PM

This supports calling

updateProgress

from your long running task.

ron

12/10/2017, 12:49 PM

I was thinking of

fun makeBook(title: String, pubname: String, chapters: List<Entry>, baseDirectory: String=".", progress: () -> Unit): Book

ron

12/10/2017, 12:49 PM

that way I can use makeBook from javafx and from the commandline

ron

12/10/2017, 1:02 PM

@edvin do you know if there is a way to pass arguments to progress? they way I defined it?

edvin

12/10/2017, 1:03 PM

I don't understand what you mean. You've defined progress as a function that accepts no parameters and returns unit?

edvin

12/10/2017, 1:05 PM

You could pass in a ProgressStatus object for example?

ron

12/10/2017, 1:08 PM

nvm found it 🙂

ron

12/10/2017, 1:08 PM

@ron uploaded a file: Untitled

-.kt

ron

12/10/2017, 1:08 PM

@ron uploaded a file: Untitled

-.kt

ron

12/10/2017, 1:16 PM

should it not be

val taskStatus : TaskStatus by inject()

edvin

12/10/2017, 1:42 PM

@ron Then you'll get the default for the scope, you probably want a specific instance for the progress bar you're showing.

ron

12/10/2017, 1:43 PM

yeah I already made it like that

ron

12/10/2017, 1:43 PM

one last thing 🙂

ron

12/10/2017, 1:43 PM

let me setup the example hold on

ron

12/10/2017, 1:47 PM

ok so when I run the code like this:

ron

12/10/2017, 1:48 PM

Copy code

class ButtonInHbox : View() {
    override val root = vbox {
        buttonbar {
            val taskStatus = TaskStatus()
            progressbar(taskStatus.progress)
            label(taskStatus.message)
            button("in a vbox").action {
                runAsync(taskStatus) {
                    IntRange(1, 100).forEach {
                        updateProgress(it.toDouble() / 100, 1.0)
                        updateMessage("$it / 100")
                        Thread.sleep(50)
                    }
                }
            }
        }
    }
}

ron

12/10/2017, 1:48 PM

the label is over the progressbar not next to it

ron

12/10/2017, 1:48 PM

if I run it in a vbox(not in a buttonbar) the label is below it (as expected)

ron

12/10/2017, 1:48 PM

the behaviour that the label is over the progressbar is expected?

ron

12/10/2017, 1:50 PM

@ron uploaded a file: 2017-12-10 14-49-24.mp4

2017-12-10 14-49-24.mp4

edvin

12/10/2017, 1:51 PM

@ron Yes, that's because of how the ButtonBar layout container "works". It has nothing to do with TornadoFX.