although I'm not sure what entryformat and groupMove would be

@amanda.hinchman-dominguez the code where this come from can get a drag event from two parts of the program either you are dragging a group (groupmove) or or an entry in a group (entryformat (bad name I know))

@edvin what about overriding methods like you do with call?

@ron I see - I'd be only dragging one tile at a time ever, so perhaps I can leave the groupmove out

or am I misunderstanding this? the group would be for the single item dragging to the group?

yup you still need to check the contentType, just in case there is a drop from outside the program I think

@ron spoken like a guy who knows his COM and OLE

@edvin uploaded a file: runAsync checks if the task is completed

how about skipping the extra runLaters() and delegate to a passed-in success or a passed-in failed block?

@carlw Sorry, I don't understand what you mean 🙂

Actually, this might be better:

@edvin uploaded a file: Don't add runLater call initially

i don't think you need the runLaters since succeed and fail are already on the queue

Provided that we can inspect

status

without tripping some exception.

sorry...i'm working with JMS today.. i meant fx thread

I am working with GWT and I sorely miss kotlin

me too...i'm forgetting more each day...had to look up a for loop syntax 😭

@edvin @Ruckus what about success = { setOnSucceeded(func) }?

@carlw Yeah, if setOnSucceeded is guaranteed to be run on the FX thread, that's fine. I think we saw that it wasn't, that's why we added it, but we might have been mistaken.

Checking the docs

/** * The onSucceeded event handler is called whenever the Task state * transitions to the SUCCEEDED state. * * @param value the event handler, can be null to clear it * @since JavaFX 2.1 */

It doesn't say, looking at the code instead..

/** * A protected convenience method for subclasses, called whenever the * state of the Task has transitioned to the SUCCEEDED state. * This method is invoked on the FX Application Thread after the Task has been fully transitioned to * the new state. * @since JavaFX 2.1 */ protected void succeeded() { }

in the field, I've seen some inconsistency with runLater() when it's expected to be run at a particular instant. the docs say that it will be run sequentially with other runLaters(), but say your succeeded is a log message?

you'd want that run right away in succeed() as in fun succeeded() { log.error("here") }

So, if you override

succeeded

it gives that guarantee, but not

setOnSucceeded

..

@ron I should maybe clarify: this drag and drop is occuring between 2 panes, and I think that complicates how I define groupmove and entry format for me

@ron what I have in total right now is the following:

i think setOnSucceeded will be ok. i'd prefer the override like you do with call, but this might be a different api than you want (passing in blocks for onSucceeded and onFailed)

Actually, we're safe @carlw. You can only modify the state property on the FX thread, and that's when these functions are being called.