https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • c

    carlw

    12/12/2017, 7:44 PM
    i'm questioning the spurious runLaters()
  • e

    edvin

    12/12/2017, 7:44 PM
    You will get an 
    IllegalStateException
    if you try to change the state on another thread
  • c

    carlw

    12/12/2017, 7:45 PM
    agreed, but succeed() is on the thread
  • e

    edvin

    12/12/2017, 7:45 PM
    @carlw But.. You can't even call setOnSucceeded from another thread, so we do need that wrapper.
  • c

    carlw

    12/12/2017, 7:45 PM
    ...or an override
  • e

    edvin

    12/12/2017, 7:46 PM
  • e

    edvin

    12/12/2017, 7:46 PM
    A lot less code, and probably better too 🙂
  • e

    edvin

    12/12/2017, 7:47 PM
    Since we're on the UI thread when this happens, the state simply cannot change while we are running.
  • e

    edvin

    12/12/2017, 7:47 PM
    We could do one more optimization though - never attach the succeeded callback if the task is no longer running.
  • e

    edvin

    12/12/2017, 7:48 PM
    I updated the code above with that check as well. I really hope this is it. Beginning some testing.
  • a

    amanda.hinchman-dominguez

    12/12/2017, 7:48 PM
    @amanda.hinchman-dominguez uploaded a file: Untitled
    -.kt
  • e

    edvin

    12/12/2017, 7:51 PM
    fail
    has the same issue of course, so I'm fixing that as well.
  • c

    carlw

    12/12/2017, 7:54 PM
    @edvin what's the initial state for the task? it's not succeeded or running, right?
  • a

    amanda.hinchman-dominguez

    12/12/2017, 7:54 PM
    @ron it technically never quite happened. I was hoping that the clipboard would have done it, but I was having syntax issues with what I wrote (hence, it was commented out)
  • e

    edvin

    12/12/2017, 7:55 PM
    @carlw No, I think it can be queued first. Good point, double checking.
  • c

    carlw

    12/12/2017, 7:55 PM
    maybe READY?
  • e

    edvin

    12/12/2017, 7:55 PM
    @carlw Yes, State.READY
  • r

    ron

    12/12/2017, 8:02 PM
    @ron uploaded a file: Untitled
    -.kt
  • r

    ron

    12/12/2017, 8:02 PM
    @amanda.hinchman-dominguez This is the complete class that does the drag&drop from a tableview to the treeview
  • e

    edvin

    12/12/2017, 8:03 PM
    It seems to be working! To think that we have had this bug for so long and it was so easy to fix.. incredible 🙂 Very sorry about this, guys.
  • u

    user

    12/12/2017, 8:06 PM
    @amanda.hinchman-dominguez commented on @ron’s file https://kotlinlang.slack.com/files/U14ECM2KV/F8DPXSXMK/-.kt: keepassFX? as in keypass or keep ass? hahaha
    -.kt
  • u

    user

    12/12/2017, 8:06 PM
    @amanda.hinchman-dominguez commented on @ron’s file https://kotlinlang.slack.com/files/U14ECM2KV/F8DPXSXMK/-.kt: I'm sorry it's 3pm here I'm tired, and I have 13yo boy humor
    -.kt
  • e

    edvin

    12/12/2017, 8:06 PM
    I've pushed a new snapshot with this glorious bugfix 🙂 I actually also fixed two other subtle bugs today, so it's worth upgrading.
  • u

    user

    12/12/2017, 8:07 PM
    @amanda.hinchman-dominguez commented on @ron’s file https://kotlinlang.slack.com/files/U14ECM2KV/F8DPXSXMK/-.kt: I'm seriously reading through it now
    -.kt
  • r

    ron

    12/12/2017, 8:08 PM
    I showed you the code for starting the drag (that complete file and the receiving part here is a short video showing it in action where an entry is dropped from a tableview to a treeview
  • c

    carlw

    12/12/2017, 8:08 PM
    @edvin is the runLater still in there for the case where you're already on the FX thread?
  • r

    ron

    12/12/2017, 8:08 PM
  • r

    ron

    12/12/2017, 8:08 PM
    keepassFX is an implementation of the keepass.info system
  • a

    amanda.hinchman-dominguez

    12/12/2017, 8:09 PM
    used for files?
  • a

    amanda.hinchman-dominguez

    12/12/2017, 8:09 PM
    That's kind of interesting, given there's an existing DataFormat(FILES) and and Clipboard you can already use
1...157815791580...2007Latest