https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • c

    carlw

    12/19/2017, 3:00 PM
    no
  • c

    carlw

    12/19/2017, 3:00 PM
    jenkins is just automated "mvn clean install".
  • c

    carlw

    12/19/2017, 3:01 PM
    it won't fix your pom
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:01 PM
    For the time being I'll add a readme for instructions
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:01 PM
    got you
  • r

    ron

    12/19/2017, 3:01 PM
    if you want I can set it up for you on jetpack?
    👍 1
  • r

    ron

    12/19/2017, 3:01 PM
    I like jetpack
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:01 PM
    I've never used jetpack before! Why do you like it?
  • r

    ron

    12/19/2017, 3:02 PM
    its jitpack ( I always mistype it)
  • r

    ron

    12/19/2017, 3:02 PM
    you give it the github repo, it will build it and you enter the jitpack information in your pom
  • r

    ron

    12/19/2017, 3:02 PM
    which version do you use?
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:02 PM
    @carlw for the time being, the lib jars you'll need is hamcrest-core-1.1.jar, json-simple-1.1.1.jar, junit-4.10.jar, and tilesfx-1.5.2.jar
  • r

    ron

    12/19/2017, 3:03 PM
    ok add this to your pom file:
  • r

    ron

    12/19/2017, 3:03 PM
    Copy code
    <repositories>
		<repository>
		    <id>jitpack.io</id>
		    <url>https://jitpack.io</url>
		</repository>
	</repositories>
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:03 PM
    @ron versions of libs?
  • r

    ron

    12/19/2017, 3:03 PM
    and in the dependencies
  • r

    ron

    12/19/2017, 3:03 PM
    Copy code
    <dependency>
	    <groupId>com.github.HanSolo</groupId>
	    <artifactId>tilesfx</artifactId>
	    <version>1.5.2</version>
	</dependency>
  • r

    ron

    12/19/2017, 3:03 PM
    and you are done
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:05 PM
    I have this for TilesFX:
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:05 PM
    @amanda.hinchman-dominguez uploaded a file: Untitled
    -.kt
  • r

    ron

    12/19/2017, 3:05 PM
    why the type pom?
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:06 PM
    but i'll go ahead and add the repo
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:06 PM
    whoops - the type is not necessary.
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:06 PM
    I took it out. I'll update the pom file and push
  • r

    ron

    12/19/2017, 3:06 PM
    that way when somebody clones your project they dont have to build tilesFx themselves
  • a

    abhinay

    12/19/2017, 3:07 PM
    @amanda.hinchman-dominguez I did create a PR with all those things cleaned out. Not sure if you accepted it.
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:07 PM
    oh dear, I took note Friday but was extremely busy. In fact, I'll take a look and accept it if I'm happy with it 🙂
  • r

    ron

    12/19/2017, 3:08 PM
    did you setup a ci for your project?
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:08 PM
    I don't think so
  • r

    ron

    12/19/2017, 3:09 PM
    if you expect to get more PR's then setting up a CI that will automatically build PR's in a seperate branch is very important as it will make do the heavy lifting of testing the project completely
1...159315941595...2007Latest