https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:09 PM
    I just use command line to work with the project and githb
  • r

    ron

    12/19/2017, 3:09 PM
    you use github to the building
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:09 PM
    that's a REALLY good idea
  • r

    ron

    12/19/2017, 3:09 PM
    look at how tornadofx does it(that is the standard way of doing that)
  • a

    abhinay

    12/19/2017, 3:09 PM
    Also, never check in class files 🙂
  • a

    abhinay

    12/19/2017, 3:10 PM
    or jars
  • r

    ron

    12/19/2017, 3:10 PM
    target dir should be in the .gitignore file
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:10 PM
    @abhinay isn't the jars necessary for people to be able to build their project?
  • a

    abhinay

    12/19/2017, 3:10 PM
    Maven takes care of dependencies for you
  • r

    ron

    12/19/2017, 3:10 PM
    all the jars needed should be handled as dependencies in your pom
  • a

    abhinay

    12/19/2017, 3:10 PM
    That's what a build tool is for
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:11 PM
    okay! So I'll pull in your PR, and I'll set up a CI
  • a

    abhinay

    12/19/2017, 3:11 PM
    Maven/Gradle/Ant all of them manages the dependencies (or jars).
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:12 PM
    what do you normally use to set up a CI?
  • a

    abhinay

    12/19/2017, 3:12 PM
    You cannot. It has conflicts as of now.
  • a

    abhinay

    12/19/2017, 3:12 PM
    I will update the PR in some time 🙂
  • r

    ron

    12/19/2017, 3:12 PM
    @amanda.hinchman-dominguez https://github.com/marketplace/travis-ci
  • r

    ron

    12/19/2017, 3:12 PM
    tells you all you need to know
  • r

    ron

    12/19/2017, 3:13 PM
    this file https://github.com/edvin/tornadofx/blob/master/.travis.yml from Tornadofx has a lot of info for you and shows how to setup to test javafx projects
  • r

    ron

    12/19/2017, 3:14 PM
    the magic is in the setup of the xvfb part where a virtual screen is added where tests can be run in
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:15 PM
    excellent! I'll get on it. @abhinay just let me know when your PR is ready. Should I delete my jars from my repo in the meantime?
  • r

    ron

    12/19/2017, 3:15 PM
    you should never check in class files or jars
  • r

    ron

    12/19/2017, 3:18 PM
    👍 2
  • r

    ron

    12/19/2017, 3:19 PM
    the only thing I always change with that is the way intelij is handled, I dont want anything from an IDE checked in
  • r

    r4zzz4k

    12/19/2017, 3:20 PM
    Yeah, some day they will probably separate user settings from project information somewhere inside .idea, but for now this is the cleanest solution.
  • r

    ron

    12/19/2017, 3:22 PM
    even the project information should not be checked in, I had a lot of trouble once when a collegue had more maven projects opened that I had and both our intellij's started choking on it as one of the *.iml files pointed to that
  • r

    ron

    12/19/2017, 3:22 PM
    so I have
    Copy code
    *.iml
    and
    Copy code
    .idea
    in gitignore file
  • a

    abhinay

    12/19/2017, 3:28 PM
    @amanda.hinchman-dominguez Updated PR! Description on what the PR does - https://github.com/ahinchman1/UI-Code-Creator/pull/2#issue-281575206
  • a

    amanda.hinchman-dominguez

    12/19/2017, 3:30 PM
    thanks Abhinay I'll take a look 🙂 Give me like 15 minutes or so, I have to make a fix for some clients on production (again)
  • r

    ron

    12/19/2017, 3:30 PM
    thos damn clients always getting in way of the fun stuff 😉
    😄 2
1...159415951596...2007Latest