@ron uploaded a file: Untitled

@ron uploaded a file:

Fun times. I'm doing full screen stage by running

find<MyFragment>(params = mapOf(...)).openWindow(...)?.apply { isFullscreen = true }

. The thing is my fragment's constructor is called two times in a row -- first by my own invocation of

find

with properly passed

params

, and the second time this stuff can be found in stack trace:

...
java.lang.Class.newInstance(Class.java:442)
tornadofx.FXKt.find(FX.kt:423)
tornadofx.FXKt.find$default(FX.kt:393)
tornadofx.FX$Companion.replaceComponent(FX.kt:262)
tornadofx.NodesKt.reloadViews(Nodes.kt:144)
...
javafx.stage.Window.setFocused(Window.java:439)
...
java.security.AccessController.doPrivileged(Native Method)
...

Of course it doesn't find any parameters and crashes in my

onDock()

later. Any suggestions?

@r4zzz4k Disable hot view reloading 🙂

Oh wow, I didn't even know it existed. Just watched your video on this -- I'm amazed. Anyway, I believe it's not hot reloading who messes with me. IIRC going fullscreen is a priviledged operation, which is automatically allowed for desktop apps, but still is probably checked. That's why I'm seeing

doPriviledged()

in the second stacktrace. I may be wrong, of course.

@thomasnield I have updated the guide and pushed it to edvin's repo. Dont know if you need to do something to make it show up in the guide

@ron Fantastic, thank you! It will show up in the guide automatically, there is a commit trigger in there 🙂

@ron thanks Ron!

I'd appreciate feedback on how idiomatically correct the current state of my wordsearch program is, particularly in the following classes: WordSearchMainView, WordGridModel, WordGridView, WordGridCellFrag. Here is the repo: https://github.com/JavaFXpert/wordsearch_tornadofx

@javafxpert uploaded a file:

@edvin et, al, I'd like to use correct TornadoFX coding practices before adding much more code.

@edvin @javafxpert Maybe you two could do a blog update to this format: https://edvin.town/leveraging-tornadofx-to-the-fullest/? Capture the idiom and tornadofx features in a code review for others

I know I got a lot out of it. I think some others on the channel thought it was cool too.

@carlw Happy to, but I have a lot to learn first 🙂

I'm setting aside some time tomorrow to update the guide. Christmas vacation has started for me.

@javafxpert Nice! I'll have a look at the code and give you some feedback tonight. I'm working at a customer's location today, so will have to catch up this evening.

@thomasnield Happy to hear it 🙂 If you see stuff that should be changed but you don't have time for it, please delegate to me and I'll contribute as well.

@edvin I was reading the guide and I noticed there is nothing about how to limit the type of input in a textfield. If you have a normal setup like this:

class EntryForm : View("Entry Form"){
    val entry : MeasurementModel by inject()
    override val root = form {
        fieldset {
            field("sys") {textfield(entry.sys)}
            field("dia") {textfield(entry.dia)}
            field("pulse"){textfield(entry.pulse)}
            field ("Time"){datepicker (entry.time)}
            button("press me").action {
                entry.rollback()
                println(entry.sys)
            }
        }
    }
}

and entry.sys is an Int your console will be filled with

Caused by: java.text.ParseException: Unparseable number: "sd"
	at java.text.NumberFormat.parse(NumberFormat.java:385)
	at javafx.util.converter.NumberStringConverter.fromString(NumberStringConverter.java:94)
	... 52 more

@edvin EventTarget.textfield extends from AbstractField which has a textProperty that seems to be used for the label and not the textProperty from javafx.scene.control.TextField which you would need to add a changeListener to check if you are actually entering numbers, do I read this correct?

@edvin morning

was my rambling a bit understandable?

@ron Good morning 🙂 You can add a formatter directly in the builder constructor, hang on, I'll show you.

its not a formatter I need, but a validator in normal javafx one would do that with a changelistener

like this: https://stackoverflow.com/questions/7555564/what-is-the-recommended-way-to-make-a-numeric-textfield-in-javafx

allthough a formatter is always handy too

I need to get my blog back online, but with being sick I dont have a lot of energy

@ron What's preventing you from adding a listener like they do in that SO issue?

the

textProperty

is not from javafx.scene.control.TextField` but from AbstractField

which is used to set the label