https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • a

    amanda.hinchman-dominguez

    01/30/2018, 12:58 AM
    oh, should I just create another image then?
  • a

    abhinay

    01/30/2018, 12:58 AM
    Exactly!!
  • a

    amanda.hinchman-dominguez

    01/30/2018, 12:58 AM
    nice. I'll do so
  • a

    abhinay

    01/30/2018, 12:58 AM
    You can fetch the image from the ImageView. Then use the image to create a new ImageView and it should do the job.
  • a

    amanda.hinchman-dominguez

    01/30/2018, 1:05 AM
    thanks!
  • c

    Carlton Whitehead

    01/30/2018, 3:11 AM
    I extracted an example app and test case from the issue I had while upgrading my TornadoFX version. Shameless SO cross-post https://stackoverflow.com/questions/48512919/java-util-concurrent-rejectedexecutionexception-when-action-calls-runasync
  • a

    amanda.hinchman-dominguez

    01/30/2018, 3:29 AM
    @Carlton Whitehead can you confirm that value of the app scope changes?
  • a

    amanda.hinchman-dominguez

    01/30/2018, 3:31 AM
    @abhinay what is the equivalent of 
    R.id.string
    or 
    R.string.string
    for kotlin?
  • c

    Carlton Whitehead

    01/30/2018, 3:38 AM
    I don't think the 
    Scope
    is really playing a role here. The 
    app.scope
    instance remains the same between tests since nothing in the test depends on a unique 
    Scope
    in this case. Looking through the TornadoFX source, I see in 
    Async.kt
    both of the thread pools are assigned as 
    val
    in global scope. So, if TestFX is closing down and trying to start back up the app between cycles, those thread pools would linger to the next test cycle in a shut down state.
  • c

    Carlton Whitehead

    01/30/2018, 3:41 AM
    So, I guess my question becomes, how do I make sure I get a clean App instance in between test cycles in a way that doesn't disturb those executors?
  • a

    abhinay

    01/30/2018, 3:44 AM
    @amanda.hinchman-dominguez R.id is from Android. Isn't it?
  • a

    abhinay

    01/30/2018, 3:45 AM
    Why do you need it in a TornadoFX application?
  • c

    Carlton Whitehead

    01/30/2018, 3:46 AM
    R is a generated class on Android used for making resources available to the program code. R.string, R.layout, etc. Doesn't seem applicable to tornadofx?
  • c

    Carlton Whitehead

    01/30/2018, 3:47 AM
    Oh
  • c

    Carlton Whitehead

    01/30/2018, 3:48 AM
    @amanda.hinchman-dominguez You probably want to use 
    messages
    https://edvin.gitbooks.io/tornadofx-guide/content/part2/Internationalization.html
  • c

    Carlton Whitehead

    01/30/2018, 3:51 AM
    Not sure what the equivalent of 
    R.id
    would be. You can assign a node's 
    id
    in your builder.
  • a

    amanda.hinchman-dominguez

    01/30/2018, 4:12 AM
    welp, that makes more sense
  • a

    amanda.hinchman-dominguez

    01/30/2018, 4:12 AM
    I did use a hashmap
  • a

    amanda.hinchman-dominguez

    01/30/2018, 4:13 AM
    it's getting late for me I'll be sure to return to this tomorrow. Kind of silly that you can't use an id natively easily
  • a

    abhinay

    01/30/2018, 6:06 AM
    Why do you need an 
    id
    ? What are you trying to achieve here?
  • c

    Carlton Whitehead

    01/30/2018, 1:19 PM
    Thanks for the super quick bug fix @edvin
  • c

    Carlton Whitehead

    01/30/2018, 1:20 PM
    I'll merge my test case and send you a PR momentarily
  • e

    edvin

    01/30/2018, 1:40 PM
    @Carlton Whitehead Thanks! Nice to squash this one 🙂
    🎉 1
  • c

    Carlton Whitehead

    01/30/2018, 2:42 PM
    I think there might be an issue with the tornadofx pom. When I do 
    mvn test
    like I see in the 
    .travis.yml
    , it doesn't appear to be running the various UI tests. At least, none of the test stages show up on my screen. When I run the whole test source root worth of tests from IntelliJ, they display, some of them fail. I ran out of time to look into it more deeply before I had to leave for work so wanted to quickly share here
  • c

    Carlton Whitehead

    01/30/2018, 3:00 PM
    It make me suspect there might have been some tech debt silently accruing while Travis builds stay green
  • r

    Ruckus

    01/30/2018, 3:09 PM
    If you mean the apps in the 
    testapps
    package, I don't believe they were ever meant to be run by travis as there's no assertions to make sure they are working properly. They're just for running manually so we can check for ourselves (and have little demos of various features to show each other while we're working on them).
  • c

    Carlton Whitehead

    01/30/2018, 3:10 PM
    I meant the unit tests
  • r

    Ruckus

    01/30/2018, 3:11 PM
    Unless I'm mistaken, all the tests in the 
    tests
    package should run though. We had an issue a while back where only some of the tests were being run (something to do with how Maven expects things to be named), but I can't remember to what extent it was fixed.
  • c

    Carlton Whitehead

    01/30/2018, 3:13 PM
    I'll take a closer look at that when I get some time (maybe tonight or Thursday)
    👍 1
  • e

    edvin

    01/30/2018, 3:25 PM
    Yeah, I know for a fact that they run on Travis, I tripped one not long ago 🙂 Hehe.. But it would be great if you could look into it @Carlton Whitehead
1...167316741675...2007Latest