Maybe something is wrong with my local environment. Wouldn't be the first time. If that is the case, I apologize in advance for all this noise

@Carlton Whitehead @Ruckus @edvin There was recently an issue with testing where they ran fine in Travis and locally (in IDEA), but if you ran them from maven on a mac things failed -- it appeared to be that tests were running in different order depending on the environment. I thought we had that taken care of (by making order unimportant), but I might have gotten something wrong in the fix. Also there might be new stuff that re-breaks it, I seem to recall there being some new stuff having to do with initialization of the FX environment.

@Carlton Whitehead It's worth pursuing, especially seeing as we've had issues with that before

@kastork Yeah, I remember! Can you check if the tests run at all still in your setup?

@edvin will do

Thanks 🙂

@edvin

mvn test

passes on mac from command line (java 1.8_162) but I don't see any of the GUI stuff popping up like it used to.

OK, I will test here soon as well. Thanks!

@edvin same result running the mvn task from IDEA. But if I

run All tests

by right clicking on the

test/kotlin

node in the IDEA project I see gui stuff going on and then the

runAsync

and

runAsyncWithOverlay

tests fail. Those are new I think.

@kastork uploaded a file: Untitled

@kastork uploaded a file: runAsyncWithOverlay

I just them both a fiew times on Wondows 10.

mvn test

appears to only build (which it does successfully), but I see no record of any tests being run. In IntelliJ,

AsyncBugAppTest.itShouldSurviveRunAsyncMultipleTimes

fails randomly with a timeout,

AsyncTest.runAsync

and

AsyncTest.runAsyncWithOverlay

both fail (same result as @kastork), and

ChildInterceptorTest.interceptorsLoaded

fails with a size of 6, not 2 (also, the expected and actual are backward in that test).

@Ruckus Looking back, I don't see test results from

mvn test

either. The task is announced, but no result message other than

BUILD SUCCESS

@kastork uploaded a file: Untitled

AsyncBugAppTest.itShouldSurviveRunAsyncMultipleTimes

is the one I just contributed. I can think of two cases where it could fail due to a timeout. 1) There might still be an underlying issue with the thread pool executors not being re-initialized in time for the second test cycle. 2) The test is just executing too slowly. There is a timeout rule on that test of 10 seconds. I set that value by taking the ceiling of double the time it was taking to execute on my laptop. Perhaps it might be necessary to raise further

@Carlton Whitehead Running it a fiew more times, it looks like it randomly does not capture the mouse, and it just stays where it was when the tests started, so it times out.

Odd. I wonder if it's caused by an environmental difference? I ran my tests multiple times locally, but only on my Linux laptop.

@kastork Did you do a git pull before running the tests?

I'm on 7232c30968a40cd36c373ecce805b875fc5abfb6

@kastork Could it be that you call app.stop() after each test, but not app.start() before?

@edvin I you mean from my PR weeks ago?

I need to make the thread pool handling a bit more robust. Will fix tonight.

OK, I committed a fix for the thread pool issues 🙂

@abhinay sorry to get back literally a day later - busy here at work. I know you said I should get the image source, I was thinking that I had to retrieve the source from imageview itself, and I thought that had to be done by setting an id to the resource string. Is there another way?

tileTarget

is where you were trying to fetch the ImageView, right? So, I am guessing that is the tile which you trying to drag and drop.

sure

And it does grab the image view, but to my knowledge, I do not know if there's a way to detect the string resource... unless that's not what I'm looking for

You don't have to look for the resource. Just fetch the image from the ImageView. Same image can be used in multiple ImageViews.

oh, maybe I misunderstood what you mean by that. I thought fetching the image meant fetching the resource, since the image is generated by a resource string. What method does that?

ImageView#getImage

😉