Channels
#tornadofx
- t
tieskedh
02/09/2018, 11:03 AMI made a bit of a mess of this change, multiple PR, multiple fixes... not my greatest action... - t
tieskedh
02/09/2018, 11:15 AM@edvin one of my most simple changes is now ready to merge 🙂 - e
edvin
02/09/2018, 11:39 AMI merged the simple one 🙂👍🏻 1 - r
r4zzz4k
02/09/2018, 1:17 PM@nimakro, the ripple effect looks awesome! 🙂😉 1 - r
r4zzz4k
02/09/2018, 2:28 PMSo if I add custom stylesheet (derived from
of course) through a service provider, then use that in my module, and add another stylesheet (again derived fromtornadofx.Stylesheet
), they are getting merged?tornadofx.Stylesheet - b
BenjaVR
02/09/2018, 2:52 PMdoes anyone has an example/walkthrough of how to print a detail page (content should fit A4 paper) with kotlin/tornadofx? - e
edvin
02/09/2018, 2:53 PM@BenjaVR That would be exactly the same way you would do it in plain JavaFX, so you can probably google that unless somebody here has experience with it and can give you some pointers - e
edvin
02/09/2018, 4:48 PM@BenjaVR I will use plain JDBC. Not because it's a best practice but just because it's generic. Using any other JDBC framework will not really be TornadoFX specific anyway 🙂👍 1 - e
edvin
02/09/2018, 4:49 PMI've said for a long time that there is nothing to using databases with TornadoFX, you don't need to do anything different than you normally do, but I keep getting requests for it, and now I had a use case so it was a good time to get it done 🙂 - r
r4zzz4k
02/09/2018, 4:50 PMHey @edvin, are you okay with replacing these https://github.com/edvin/tornadofx/blob/74136a25cb1c68b5a93b54fcdfe28b8d3faa291c/src/main/java/tornadofx/ItemControls.kt#L924-L930 withCopy codeval selectedItemDirtyState: ObjectBinding<TableColumnDirtyState<S>?> by lazy { objectBinding(tableView.selectionModel.selectedItemProperty()) { getDirtyState(value) } } - r
r4zzz4k
02/09/2018, 4:50 PM(I'm working on PR for avoiding
as promised some time ago, so that's the reason for this question)!! - e
edvin
02/09/2018, 4:51 PM@r4zzz4k I wonder why I didn't use lazy... Hmm - e
edvin
02/09/2018, 4:51 PM@r4zzz4k I see no reason why it shouldn't be lazy, so I say go for it 🙂 - r
r4zzz4k
02/09/2018, 4:51 PMYep, I didn't see also. Cool, thanks 🙂👍 1 - r
r4zzz4k
02/09/2018, 5:00 PMhttps://github.com/edvin/tornadofx/blob/74136a25cb1c68b5a93b54fcdfe28b8d3faa291c/src/main/java/tornadofx/Messages.kt#L36 The most elegant
I've seen 😄KotlinNullPointerException😂 2 - r
r4zzz4k
02/09/2018, 5:38 PMOf course I've made PR and forgot to run tests. Travis should do that for me, right? - c
Carlton Whitehead
02/09/2018, 5:53 PMIt will actually run the tests as of today, as long as your branch is caught up with master - c
Carlton Whitehead
02/09/2018, 5:54 PMThere was an issue in the POM that had been causing the Maven surefire plugin to not run the tests. - r
r4zzz4k
02/09/2018, 5:55 PMI see, thanks. - c
chrbongardt
02/09/2018, 7:31 PMHi guys👋 2 - e
edvin
02/09/2018, 7:31 PMHi Christian 🙂 - c
chrbongardt
02/09/2018, 7:32 PMJust discovered tornadoFX and it's a wonderful addition to our development stack 😄 - e
edvin
02/09/2018, 7:32 PMHappy to hear that 🙂 - c
chrbongardt
02/09/2018, 7:32 PMLove it - c
chrbongardt
02/09/2018, 7:32 PMI have a question regarding the wizard - c
chrbongardt
02/09/2018, 7:33 PMI'm trying to get the wizard example of the guide working - but I've been failing for the past hour 😛 - c
chrbongardt
02/09/2018, 7:34 PMWhen I launch the wizard, how should I bind the Model to the wizard itself? - c
chrbongardt
02/09/2018, 7:34 PMIn the example I see that it's Injected, but I can't see how I should do that.. - c
carlw
02/09/2018, 7:35 PM@edvin if you're working on an initialization sequence...i usually rely on the onShown (onDock) a lot rather than some of the other JavaFX stuff like start(). This is so that I can extract credentials and show progress after the app loads