Channels
#tornadofx
- e
edvin
02/10/2018, 10:35 AM@edvin uploaded a file:DB Activity Indicator▾
- t
tieskedh
02/10/2018, 12:55 PM@edvin I had a look at improving the layout of the code by inserting enters, but I'm not finishing it. The reason is that I cannot find a great style for the whole code. On one method I like to create it a small block and on the next I find a long line looking better. This means that the changes I want to make, make the code look uglier. I think I can better fix the code by doing some funcitonality-refactorings. One of the best ways in my opinion is the difference between if-else and when, where if-else is the replacement of the shorthand if. - e
edvin
02/10/2018, 2:41 PM@tieskedh I'm battling with this all the time myself as well. If we're going to refactor we should probably add some tests as well. The last time around we introduced a few bugs if you remember 🙂 - t
tieskedh
02/10/2018, 2:44 PMI do - t
tieskedh
02/10/2018, 2:50 PMI think I should check out the tutorial and program a bit with TornadoFX, before I can say usefull things about it... - e
edvin
02/10/2018, 2:54 PMThat's probably a good idea. To think of all you have contributed without even using it is pretty amazing 🙂 - a
amanda.hinchman-dominguez
02/10/2018, 7:23 PMCopy code----------------datagrid(controller.tiles) ---------------------- Nav Find OpenCat Library Ask Marketing Share Track Fastlane News Playbooks Workspace New Messages Contacts Recently Added Image Link Build Open File Collaborate Content Analytics Sales Analytics Browse My Files New Content My Favorites My Creations Recommendations Bookmarks Build Your Own Grab And Go Featured Content Responses Quick Links File Popularity iFrame Opportunities Recent Files Favorites Links Category Links Package Search Upload Wizard -----------Datagrid output on cellFormat { graphic = cache { it } }-------------- Nav Find Nav Find Nav Find Nav Find Nav Find Nav Find OpenCat Library OpenCat Library OpenCat Library Ask Marketing Share Ask Marketing Share Ask Marketing Share Nav Find OpenCat Library Ask Marketing Share - j
jmmk
02/10/2018, 10:55 PMIn the
insiderowExpander
, is there a way to "draw a new box"? If for example I just add atableview
with some elements, I will still be inside the table and vertical lines will cross through the content However, when I add avbox
orlistview
, it will "clear" the lines and create a new blank space. Can I accomplish the same thing without these (I don't need a list or table)?tableview - a
abhinay
02/11/2018, 3:59 AM@jmmk If you want to get rid of the Table lines, just assign your parent container a background color. - e
edvin
02/11/2018, 7:54 AM@r4zzz4k @tieskedh Thanks for the PRs. That was a hefy cleanup 🙂 Took me a while to validate everything but it looks great. Merged now! - e
edvin
02/11/2018, 7:57 AM@jmmk All content added to the rowExpander will be treated equally, and appear below the row. Show the code and we'll figure out what's happening here. - t
tieskedh
02/11/2018, 8:37 AM@edvin I was uncertain about adding the suggestions to the PR but adding another PR just to "fix" the flow of another PR didn't seem logical to me. A PR called refractor PR632 doesn't feel right to me and I don't know if it feels right for @r4zzz4k... So a question for the next time: can I add comments like this to a PR and say "need improvement"? Or is the way to do this to add PRs called cleanup-PR632? (it feels especially bad when they are just 2/3 changes) - t
tieskedh
02/11/2018, 8:43 AM(or even better, I place the commits and you tell if you agree and then ask for those improvements) - e
edvin
02/11/2018, 10:06 AM@tieskedh I don't think a new PR even need to reference the old PR, it's just an improvement on the code in head right now - t
tieskedh
02/11/2018, 12:01 PM@edvin partly agree, as it is not very clea what I'm refactoring at that moment. Is there a reason that EventTarget.field (forms.kt[57]) does not use opcr for the lambda? - e
edvin
02/11/2018, 12:02 PM@tieskedh No, that's an oversight for sure! - t
tieskedh
02/11/2018, 12:05 PMok, I'm now refactoring that code as well as also. (I don't like the function opcr very much, as it is not immediately clear that it returns itselves, so I made an internal extension-function attachTo with two lambda's (one for or own usage and one to pass the op to the parent. But you will see it at the PR. - e
edvin
02/11/2018, 12:09 PMOK! - c
Carlton Whitehead
02/11/2018, 12:54 PMWhat does opcr mean? Is it an acronym? - t
tieskedh
02/11/2018, 12:55 PMI don't know, but it attaches to the parent and invokes a lambda - t
tieskedh
02/11/2018, 12:56 PMmaybe the op stands for operation, cause all the lambda's are called op. - e
edvin
02/11/2018, 1:13 PM@tieskedh Is onto something. I didn't really know what to call it, so it was an acronym for something like "op connect & return" - e
edvin
02/11/2018, 1:13 PMIt was just meant to be used by the framework, but I've seen people use it in their own code as well 🙂 - t
tieskedh
02/11/2018, 1:15 PMsounds logical. Maybe add it to the description? - e
edvin
02/11/2018, 1:18 PMDoing it now 🙂 - e
edvin
02/11/2018, 1:19 PMDone👍 3 - e
edvin
02/11/2018, 5:46 PMI just found out that
didn't listen for changes in nested columns. Committing a fix soon.onEditCommit - e
edvin
02/11/2018, 5:54 PMFixed 🙂 - e
edvin
02/11/2018, 6:12 PMNeat little trick for saving entities with a composite primary key: Use the update return value (number of items updated) to determine if you should do insert instead.