https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    02/11/2018, 6:15 PM
    I'm wondering if I should add named parameters or at least automatic indexing of parameters to the JDBC demo. Without it you're likely to introduce bugs as you evolve your model.
  • e

    edvin

    02/11/2018, 6:15 PM
    I said to myself that I wouldn't create yet another JDBC wrapper, but this thing is so hard to look at and not scratch 🙂
  • t

    tieskedh

    02/11/2018, 6:18 PM
    I haven't seen the code, but maybe you can use exposed?
  • e

    edvin

    02/11/2018, 6:20 PM
    I didn't want to use a framework, that was the main point really.
  • e

    edvin

    02/11/2018, 6:20 PM
    So I guess I should just leave it alone 🙂
  • t

    tieskedh

    02/11/2018, 6:22 PM
    ah, then writing another wrapper is indeed a bit odd. Writing a framework to avoid using a framework...
  • t

    tieskedh

    02/11/2018, 6:24 PM
    I'ma bit slow with my PRs... Everytime I am refactoring something, I end up doing other things as well and in the end refactoring the whole codebase, which makes the PR way to big...
  • t

    tieskedh

    02/11/2018, 6:25 PM
    But I added another PR
  • e

    edvin

    02/11/2018, 6:25 PM
    Yeah, I do have a few helper functions so I can get away it for now, but adding that parameter feature will make it look like a framework 🙂
  • e

    edvin

    02/11/2018, 6:26 PM
    @tieskedh Haha, OK 🙂 I will look at it tomorrow, trying to finish what I need for the demo.
  • t

    tieskedh

    02/11/2018, 6:36 PM
    ok. Is there a reason why we use urls in the docs, instead of refering to the objects in multiple places like Nodes.kt[1121]?
  • t

    tieskedh

    02/11/2018, 7:51 PM
    @edvin If I set region.paddingHorizontal to 8. Then, without changing, I ask it again. The result will be 4, right?
  • t

    tieskedh

    02/11/2018, 7:57 PM
    but if i say padding = insets(horizontal = 8 ) then both left and right will be set to 8. so if I ask it, the result will be correct
  • t

    tieskedh

    02/11/2018, 8:03 PM
    does this mean that the setter of horizontalPadding is wrong, or both the getter and the helper-function?
  • t

    tieskedh

    02/11/2018, 8:08 PM
    or is this a feature?
  • e

    edvin

    02/11/2018, 8:10 PM
    @tieskedh The way I chose to interpret the getter value might need revisiting. Not able to look at it right now.
    👍🏻 1
  • t

    tieskedh

    02/11/2018, 8:14 PM
    i'll make a PR
  • t

    tieskedh

    02/11/2018, 9:09 PM
    done
    🎉 1
  • a

    amanda.hinchman-dominguez

    02/12/2018, 2:19 AM
    @abhinay datagrid portion.
  • a

    amanda.hinchman-dominguez

    02/12/2018, 2:20 AM
    @amanda.hinchman-dominguez uploaded a file: datagrid
    datagrid.swift
  • a

    abhinay

    02/12/2018, 2:43 AM
    @amanda.hinchman-dominguez There is nothing wrong in what you see. 
    cellFormat
    in dataGrid is accessed from 
    updateItem()
    and multiple calls to updateItem of the Cell is just a side effect of the way cells are rendered.
  • a

    abhinay

    02/12/2018, 2:44 AM
    If you see correct results in the UI then everything is working as it should.
  • a

    amanda.hinchman-dominguez

    02/12/2018, 2:48 AM
    @abhinay the results in the UI are not correct. That console printout shows repetitive tile renderings, but I'm not sure where it's coming from
  • a

    amanda.hinchman-dominguez

    02/12/2018, 2:49 AM
    in debugging, tileBuilderController.tileList has all of the tiles, so I was thinking that it might be possible that something within datagrid is rendering it differently somehow
  • a

    abhinay

    02/12/2018, 2:50 AM
    What results are you expecting on the UI?
  • a

    abhinay

    02/12/2018, 2:54 AM
    The repetitive tile renderings in console are actually the calls made to 
    updateItem
    on the DataGridCell. It is managed internally and you shouldn't base your estimations by the number of times it is called 🙂
  • a

    amanda.hinchman-dominguez

    02/12/2018, 3:36 AM
    I expected the UI to render all the tiles in the tilelist
  • a

    amanda.hinchman-dominguez

    02/12/2018, 3:36 AM
    I'm not necessarily concerned with the number of cells, but rather the fact that there should be no repetitive tiles in the datagrid
  • a

    amanda.hinchman-dominguez

    02/12/2018, 3:38 AM
    Okay, that makes more sense, but in the UI itself, only the first 10 are rendered and then creates the first 10 over and over again
  • a

    abhinay

    02/12/2018, 3:53 AM
    Is there a way to replicate the behaviour that you are talking about? All I get iterating through the tileList is 
    a_block, b_block... g_block
    🙂
1...169616971698...2007Latest