A good point, let me see if it can handle tiles that large

I'll let you know

@abhinay it looks like datagrids might have a limit?

but I'm not sure. I'm making a push so you can pull and take a look. There's sets of 8 repeated 5 times

It's unclear to me right now how that data is organized

@abhinay I'm a bit tired, but tomorrow morning I'll look at your longer PR. One file looks good but the other ones would be better for me to view on a larger monitor 🙂

Cool 👍

I did make a push in the meantime

I THINK it looks like it's doing the same thing in the project, but it's harder to tell because the title is harder to read.

Will pull and check

It looks like the caching is causing the issue. If you replace :

cellFormat {
    graphic = cache { it }
}

with

cellFormat {
   graphic = it 
}

things run fine. This makes sense because VirtualFlow reuses cells. In this case, the items are cached and don't get updated as you scroll through the VirtualFlow.

I also see that Datagrid has a

cellCache

property. Unfortunately, it has no docs 😛 May be @edvin can throw some light on when to use each of those?

@chrbongardt commented on @edvin’s file https://kotlinlang.slack.com/files/U0F3291QE/F9735NSRK/-.kt: What about JOOQ? https://www.jooq.org/

@chrbongardt The whole point was to not use a framework, so people can choose. All I'm really showing is how to tie a datasource into the TornadoFX life cycle, and that turned out to be very easy and convenient 🙂

@amanda.hinchman-dominguez @abhinay I've added the following comment to

cellCache

now:

/** * Assign a Node to the graphic property of this cell. The graphic is cached and will be reused * for whatever cell is currently displaying the current item. Cells will in their life cycle be * used to display serveral different items, but using this function will make sure that there is * never a mismatch between the cached graphic node and the item it was created for. */ fun cellCache(cachedGraphic: (T) -> Node) { this.cellCache = cachedGraphic }

So

cellCache

just requires you to return a Node, and it will be attached to the graphic property of the cell, and matches with the current item for the cell.

Now for

Node.cache

, this is the current docs:

@edvin uploaded a file: Node.cache

@nimakro Nice! It was bound to happen 🙂

@tieskedh Very nice work once again! Merged your PR's.

If you're using cell caching or fragments I highly recommend reading my answer on this issue: https://github.com/edvin/tornadofx/issues/635

@edvin So, effectively

cellCache

does the same thing as

Node.cache

+ an item binding would have done for cells?

@abhinay Yes 🙂

@abhinay But Node.cache is more flexible, as it doesn't require you to bind directly to the graphic property.

Yes, makes sense. Thanks for the quick update on the docs 👍

I'll start doing that more instead of just answering questions in the channel 🙂

How to update the table data, I am trying to use the refresh but it is not working

?

@mariofelesdossantosjr Depends on your model. If you have all properties on your model as JavaFX properties, most of the work is handled internally.