https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • c

    carlw

    04/04/2018, 8:22 PM
    @amanda.hinchman-dominguez Can there be more than one Workbench?
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:25 PM
    there is only one workbench
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:26 PM
    @amanda.hinchman-dominguez uploaded a file:

    multiple options, but between the workbench and the gui, there are 3 components total▾

  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:28 PM
    The workbench is a view, and there is a component displaying a nested 
    GridPane
    view. Trying to decide whether the component should be a view or fragment. Now that I've slept on it, perhaps I should make the fragment scoped to handle sharing the single controller
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:28 PM
    I didn't like having all the controller methods in the fragment because of the heavy loading for a single instance, and the functionality is always the same no matter what the fragment generates.
  • b

    bkenn

    04/04/2018, 8:29 PM
    What are you trying to scope? The tiles?
  • c

    carlw

    04/04/2018, 8:31 PM
    If there's more than one GridPane view, then it can't be singleton scoped ("View") anyway
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:31 PM
    I have a scope already, and that passes the appropriate model to use when generating the 
    GridPane
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:32 PM
    What I need is a scope for a fragment to use in a controller
  • b

    bkenn

    04/04/2018, 8:40 PM
    The 
    GridPane
    , if there is only one, should share the global scope of the application and each 
    Tile
    should have their own scope on creation.
  • b

    bkenn

    04/04/2018, 8:40 PM
    You can have a 
    Tile
    as a 
    View
    if its scoped
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:51 PM
    A 
    Tile
    is only an object in this instance
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:53 PM
    The 
    GridPane
    sits within another component, because the 
    GridPane
    creation is meant to be a new generation. The 
    Tiles
    are actually an object from 
    TilesFX
    , and can be dragged-and-dropped to create a customized dashboard
  • a

    amanda.hinchman-dominguez

    04/04/2018, 8:54 PM
    That outer component has a menu and a sidebar that can be used to customize and build out a gridpane dashboard
  • b

    bkenn

    04/04/2018, 9:06 PM
    @amanda.hinchman-dominguez To clarify, what is workflow for the application? I just started to review the app and it seems like the standard workflow is as such: 1. Select grid type 2. Customize tiles with color and icons 3. Save grid info and tile info in json format Am I correct?
  • a

    amanda.hinchman-dominguez

    04/04/2018, 9:33 PM
    yep!
  • a

    amanda.hinchman-dominguez

    04/04/2018, 9:34 PM
    I've been multitasking everywhere, but essentially, I need to put actually do 3 - I believe I do have the information saved as a json model, but I need to check that the saved information is correct
  • a

    amanda.hinchman-dominguez

    04/04/2018, 9:34 PM
    eventually I'd like to have it transferred to xml format or code itself, but I just haven't fully thought through the best outcome
  • a

    amanda.hinchman-dominguez

    04/04/2018, 9:37 PM
    What I still have left to do before I leave it alone for a while: testing UI components and functionality, fixing image drop behavior and coming back to look at the logic for tile drop. I felt that the code was becoming increasingly complex and I know I need to come back to clean it up majorly.
  • b

    bkenn

    04/04/2018, 10:03 PM
    You are correct in wanting to scope the application but you have instantiated the scoping in the wrong place. I have forked your app and applied some changes. I'll submit a PR and you can take a look. I noticed that when you hit 
    Return to Workbench
    , the 
    Grid
    would not use the selected 
    Grid
    because it was working with Views with no new scope thus using the cached 
    TileGUI
    .
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:01 PM
    hmmmm
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:02 PM
    I don't necessarily need a scope for returning to the workbench, maybe I'm misunderstanding.
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:02 PM
    But let me see what you have to find where the scope should be placed!
  • b

    bkenn

    04/04/2018, 11:10 PM
    The scope is for 
    TileGUI
    . When you select a 
    Grid
    from the 
    Workbench
    you want that grid to be scoped. This means that any other 
    Views
    or 
    Fragments
    created from 
    TileGUI
    are using the 
    Scope
    created by the 
    Scope
    in 
    WorkbenchController
    line 23 unless specified otherwise. This is beneficial because if you dont want to save the current state of the tiles you can 
    Return to Workbench
    and create a new 
    TileGUI
    with a new 
    Scope
    .
  • h

    Hamza

    04/04/2018, 11:13 PM
    how often do animation timers run?
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:14 PM
    I completely misunderstood - thanks for clarifying!
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:15 PM
    That makes sense, I think I went a level too deep passing in parameters
  • a

    amanda.hinchman-dominguez

    04/04/2018, 11:27 PM
    @bkenn I started looking, but I need more time to finish reviewing the changes. I have to run some errands but I'll keep looking tonight
  • r

    Ruckus

    04/04/2018, 11:29 PM
    @Hamza The 
    handle
    method gets called once per frame. By default JavaFX is throttled to 60fps.
  • h

    Hamza

    04/05/2018, 2:04 AM
    okay, thanks!
1...174717481749...2007Latest