https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • c

    carlw

    06/05/2018, 3:42 PM
    sometimes you see "blank" which is null+emptystring+only whitespace
  • a

    amanda.hinchman-dominguez

    06/05/2018, 5:38 PM
    Some feedback on the code:
  • a

    amanda.hinchman-dominguez

    06/05/2018, 5:39 PM
    @carlw 
    enableWhen { selectedReadings.emptyProperty().isEqualTo(SimpleBooleanProperty(false)) }
    can be changed to 
    enableWhen { !selectedReadings.emptyProperty() }
  • a

    amanda.hinchman-dominguez

    06/05/2018, 5:40 PM
    and I tried to simplify the code greatly but ran into an NPE. Not sure where exactly but according to the error message I'm missing heights and widths
  • a

    amanda.hinchman-dominguez

    06/05/2018, 5:41 PM
  • c

    carlw

    06/05/2018, 5:43 PM
    do you know if !selectedReadings.emptyProperty() is the same as selectedReadings().emptyProperty().not() ?
  • a

    amanda.hinchman-dominguez

    06/05/2018, 6:26 PM
    @carlw 
    .not()
    is the inverse boolean, so I believe it is the equivalent
  • a

    amanda.hinchman-dominguez

    06/05/2018, 6:31 PM
    @carlw If you want validation, @edvin released a new version that allows you to filter your input by Double or Long only (otherwise return ""). I was thinking about placing in a workaround eventually, but wanted to get a working version of what I had first
  • c

    carlw

    06/05/2018, 6:32 PM
    i'll finish typing it up tomorrow with a footnote mentioning the lack of validation
  • c

    carlw

    06/05/2018, 6:32 PM
    then i'll look at another post with improvements that focus on the structure of the program and functions like validation. (maybe >1 more post)
  • t

    thomasnield

    06/05/2018, 8:20 PM
    I came up with a utility I have had hundreds of use cases for, and I don't know if there is something already we built that does this.
  • t

    thomasnield

    06/05/2018, 8:22 PM
    I frequently need an 
    ObservableList
    and 
    ObservableSet
    that keep track of their "dirty" state based on what they originally contained. They can also be rebaselined to the newest contents, as well as "reset" to the original contents.
  • t

    thomasnield

    06/05/2018, 8:22 PM
    @thomasnield uploaded a file: Untitled
    -.kt
  • t

    thomasnield

    06/05/2018, 8:23 PM
    Would this be something we should include in TornadoFX?
  • t

    thomasnield

    06/05/2018, 8:23 PM
    Or is this too niche?
  • c

    carlw

    06/05/2018, 8:27 PM
    SnapshotObservableList? with pointer system of versions like "HEAD" or a number?
  • t

    thomasnield

    06/05/2018, 8:28 PM
    @carlw nice idea, although the only use case I can think of is an "undo" feature.
  • t

    thomasnield

    06/05/2018, 8:29 PM
    Haha 
    ForkableSnapshotObservableList
  • t

    thomasnield

    06/05/2018, 8:29 PM
    or 
    ForkableMergablePullrequestableObservableList
  • a

    amanda.hinchman-dominguez

    06/05/2018, 8:29 PM
    is this dirty-state checking without models?
  • c

    carlw

    06/05/2018, 8:29 PM
    sounds like a RAM-based datasource. you manipulate the observablelist and commit when you're ready
  • t

    thomasnield

    06/05/2018, 8:30 PM
    @amanda.hinchman-dominguez Yes, the `ObservableList`/`ObservableSet` takes charge of its own dirty state tracking.
    👍 1
  • t

    thomasnield

    06/05/2018, 8:31 PM
  • c

    carlw

    06/05/2018, 8:31 PM
    maybe DeferredObservableList?
    🤔 1
  • c

    carlw

    06/05/2018, 8:31 PM
    ...hold off on the notification until the commit() or rollback() happens
  • c

    carlw

    06/05/2018, 8:31 PM
    DelayedObservableList
  • t

    thomasnield

    06/05/2018, 8:31 PM
    Isn't 
    DirtyXXX
    the semantics with UI editing though?
  • c

    carlw

    06/05/2018, 8:32 PM
    yep
  • c

    carlw

    06/05/2018, 8:33 PM
    TransactionalObservableList? ReactiveObservableList 😬
  • t

    thomasnield

    06/05/2018, 8:34 PM
    Haha I was just about to say this sounds Rx-y.
1...179817991800...2007Latest