it's wrapping in TreeItem so that nested structures work, right @Ruckus

@carlw That shouldn't matter. Let me check it out.

i'm going to work on a populate/itemFactory/childFactory blog post

Yeah, I agree with @orangy. It should just be

(T) -> Iterable<T>?

. The only change to make this work would be to change the line

val children = childFactory.invoke(item)

to

val children = childFactory.invoke(item.value)

.

one factory to wrap the items?

@Ruckus yep, otherwise it is a bit inconsistent and reduces potential for code reuse for hierarchies

Agreed

So I made myself a function and now it looks like this:

bindTree(modelProperty,
                    {
                        TreeItem(it).apply { isExpanded = true }
                    },
                    {
                        (it as? ContainerItem)?.children
                    }
            )

And it binds stuff, initializes, etc

Less intermediate properties, all declarative. Nice 🙂

Also, I can't think of a good reason

itemFactory

wouldn't default to

::TreeItem

.

bindTree

is as simple as

source.attach { root = create(it, itemFactory, children) }

with the attach function above

and

create

is pretty much populate with the change to childrenFactory

In general, do you folks keep API stable? Or are you still changing it a lot and there is a chance such things (like childrenFactory) can go into master?

it's encouraged to add what's needed - that would definitely be a great feature for TornadoFX - there are releases but there's usually snapshots for in-between

@edvin is usually pretty quick to review changes

That’s not an addition, it’s a breaking change

I'd say in general we try to keep the API stable where possible. If we really want to make such a change without breaking things, we'll use

@JvmName

where possible, otherwise we'll add a new function with a different name.

Sometimes, however, breaking changes are worth it. But we don't really use semver.

I wonder how should I report all these ideas/issues/questions/improvements? I’m in rapid prototyping mode, so move fast, break things, etc. But I think it would be nice to log them somewhere. Or may be not. May be in few days I get used to it and it’ll come natural 🙂

Or may be someone else taking notes? 😉

You could always throw an issue up on GitHub where it could be further discussed. Just mention in the title or description if it's a proposal/bug/whatever, and someone can add the appropriate flag.

Though admittedly we don't always do the best job keeping up on those 🙂

@edvin does pretty dang good, but the occasional issue slips through the cracks here and there.

How to update view when using bindChildren?

clear before each draw?

probably not. you're updating an entire View's scene graph including the control holding the children?

Yep.

Sry for my sleepy questions) I have one more how to select item in listview programmaticaly?

selectWhere my answer.

@edvin did you see my message about javax.json not being found when I upgraded to 17-snapshot