https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • a

    aimozg

    07/16/2018, 2:07 PM
    if I do not change treeView.root node and call populate() again I get duplicate items in the root
  • c

    carlw

    07/16/2018, 2:08 PM
    @aimozg Check this post out if you're working with WeakInvalidationListener. http://bekwam.blogspot.com/2015/08/invalidationlistener-not-called.html
  • a

    aimozg

    07/16/2018, 2:10 PM
    yes, I've even written the 
    onChangeWeak
    extension which returns the listener that should be saved somewhere
  • g

    gtnarg

    07/16/2018, 2:10 PM
    @aimozg - I see your problem - if populateTree incorporated WeakListChangeListener - could they be stored as a property in the rootTreeItem - when it goes out of scope - they get gc'd?
  • a

    aimozg

    07/16/2018, 2:11 PM
    Copy code
    private val weakListeners = ArrayList<Any>()
//...
contextualCurrentProperty.onChangeWeak { cts ->
    // ...
}.addToList(weakListeners)
  • c

    carlw

    07/16/2018, 2:11 PM
    When you go out of scope, can you itereate and make an explicit removeListener() call?
  • a

    aimozg

    07/16/2018, 2:11 PM
    Well I can do anything if I start changing the populateTree
  • a

    aimozg

    07/16/2018, 2:14 PM
    @gtnarg if listeners get gc'd when root is replaced with a new dataset is actually a solution, not a problem. If I track properly the current root, of course
  • g

    gtnarg

    07/16/2018, 2:17 PM
    I intended it as a solution - looking for a storage location (at a framework level) so that populate could modified to handle your use case
  • a

    aimozg

    07/16/2018, 2:17 PM
    right
  • a

    aimozg

    07/16/2018, 2:18 PM
    the other possibility is to make listener remove itself when the TreeItem is detached from TreeView
  • a

    aimozg

    07/16/2018, 2:18 PM
  • a

    aimozg

    07/16/2018, 2:19 PM
    Copy code
    (children as? ObservableList<T>)?.addListener(ListChangeListener { change ->
    check if 
    item
    is still inside... TreeView is not accessible at the moment but is at the call site (TreeView<T>.populate)
  • c

    carlw

    07/16/2018, 2:22 PM
    I think the framework should keep track of the listeners it creates for later removal.
  • c

    carlw

    07/16/2018, 2:23 PM
    I lived this memory leak back in 2015.
  • c

    carlw

    07/16/2018, 2:23 PM
    (See referenced post)
  • g

    gtnarg

    07/16/2018, 2:24 PM
    I suggest modifying populate and submit a PR (or at least create an issue).
  • a

    aimozg

    07/16/2018, 2:24 PM
    @carlw Yes; and tornadofx uses 
    addListener { lambda never tracked anywhere }
    quite often
  • a

    aimozg

    07/16/2018, 2:26 PM
    There was another... (too philosophical to be called a bug, so) situation I had with observables
  • a

    aimozg

    07/16/2018, 2:28 PM
    I have a Property<ObservableList<T>>, and the listener on that property adds ListChangeListener to new value and removes from old
  • a

    aimozg

    07/16/2018, 2:29 PM
    Funny thing is when the property holds empty list A, and I assign empty list B, they are considered 
    equals()
    and the listener isn't bound to B
  • a

    aimozg

    07/16/2018, 2:29 PM
    Even when it gets modified later
  • a

    aimozg

    07/16/2018, 2:30 PM
    @aimozg uploaded a file: Untitled
    -.kt
  • a

    aimozg

    07/16/2018, 2:30 PM
    this is my solution
  • g

    gtnarg

    07/16/2018, 2:31 PM
    Does SimpleListProperty have the same behaviour?
  • c

    carlw

    07/16/2018, 2:31 PM
    @aimozg The Property variable's identity is the same pre and post assignment?
  • c

    carlw

    07/16/2018, 2:32 PM
    Your solution is to create another unique object with observable() that's different?
  • a

    aimozg

    07/16/2018, 2:33 PM
    @gtnarg you're right. it doesn't (ListPropertyBase performs identity check)
  • c

    carlw

    07/16/2018, 2:35 PM
    @aimozg isn't the default behavior of List.equals() what you want?
  • a

    aimozg

    07/16/2018, 2:36 PM
    @carlw I had SimpleObjectProperty<ObservableList<*>> which does not fire update event if the previous value 
    equals(newValue)
    , but they are separate observable lists
1...183018311832...2007Latest