I pretty much gave up on SVG in JavaFX a while back (before I ever heard of Kotlin), but with the changes in JavaFX 11, I'm hoping this will be addressed in the near-ish future (I'm also hoping for better OpenGL integration).

You can look at the

SVGIcon

class in TornadoFX, but I don't know much about it, so someone else may be able to help you more.

Hmm, so what do you do for hidpi displays and such? Make lots of PNGs?

Anyway, I tried this:

private val defaultIcon = SVGIcon(javaClass.getResourceAsStream("default.svg").reader().readText())

Pretty much, though I believe there are some built-ins and helpers for automatic image scaling. I tend to create rather spartan interfaces, so I'm probably not the best resource on that 🙂

And then:

cellFormat {
                text = it.toString()
                icon = defaultIcon
            }

No icons…

What is the text for

default.svg

? I believe

SVGIcon

uses

SVGPath

under the hood, so it can only use the actual path string and not the whole SVG XML specification.

Ouch… Yep, it’s full XML

Maybe someone else can jump in and give more insights.

For simple SVGs, you can extract the path from the file and use them directly in SVGPath or via css.

Hmm… So, I have to create ImageView for each occurrence. Not obvious. But then…

button {
            text = "Attached"
            icon = imageview(defaultIcon) // image is there
        }
        button {
            text = "Created"
            icon = ImageView(defaultIcon) // no image
        }

Still can’t set icon for

TreeItem

, but at least I know it loads 😞

imageview

is created for TornadoFX DSL. While

ImageView

is the actual JavaFX reference,

imageview

can be used to create an

ImageView

using:

imageview {
    image = location for image 
}

Now I’ve found The Magic Spell…

cellFormat {
                text = it.toString()
                graphic = imageview(defaultIcon)
            }

Passing

ImageView

to

TreeItem

constructor didn’t work.

@orangy you shouldn't use tornadofx dsls in this circumstance because they attempt to attach to the parent node.

I was simply using wrong property.

icon

is something else, or may be from a different receiver (use

@DslMarker

!). The correct property is

graphics

, and

ImageView

instance is enough. No idea why it didn’t work in constructor of

TreeItem

though…

I think it’s because the binding mechanics is clearing

TreeItem

instances before reusing them.

Different scopes bit me once before. However, I believe

@DslMarker

is difficult to implement right now as the current code relies on JavaFx's

EventTarget

Another "fun" thing to discover is that there's

item

in

Cell

and

treeItem

in

TreeCell extends Cell

@orangy We have investigated using

@DslMarker

and while it would remove confusion, it would break existing code and make some things harder. We are still considering it for 2.0. It would make sure the user code is more robust and works as expected for sure.

@carlw You're correct about the EventBus, we should make sure every listener gets the event, or maybe introduce a

shortCircuitOnError

property perhaps?

@carlw I've committed a fix to allow the EventBus to deliver events to all subscribers and log if a subscriber throws an error. If there is any interest in

shortCircuitOnError

(maybe call it

failFast

) we can add that easily

https://pastebin.com/meBADsSP How i can add listener to my combobox cell after data rendering? i.e. now ChangeListener works when i render and change data

I need the ChangeListener to work when I select a value with the mouse, rather than data render

I'm receive data from api, render it to combobox cell, and when combobox selectedValue is change, i'll need send this change to api

@Roman That code is not very TornadoFX 🙂 It can be improved a lot - can you post a runnable sample and I'll show you?

@edvin I know, but I'm trying to release requirements and looking for javafx (

@Roman I can't run this code because it references other classes in your project 🙂 Maybe a minimal sample?