Can I make a request for 2.0? 😃

Deprecate the

fail

in

runAsync { } success { } fail { }

to be replaced with

failure

. Reason being that

success

and

fail

are different parts of speech. Every time I see or write those, it makes me do a double take.

not anymore! hashtag-fail

#fail

won't compile 😜

Hey guys! Quick question. I'm working on having a dark and light theme for a tornadofx application that i'm working on. So far I've been having some trouble finding the "best" way to implement this. I've gone done a few different paths but haven't really found a solution that I was looking for. I was wondering how could i do this using tornadofx? or would I benefit from just following some JavaFX resources/examples? Thanks for you response in advance

AuthRequest is my JsonModel

Probably a missing import. These functions are extension functions, defined in

tornadofx.Properties

. I usually go for

import tornadofx.*

. You might want to install the intellij plugin. The plugin can autogenerate the property delegates for you

ok ill try that thanks!

@SiebelsTim Yep! that was it! Thanks again!

@Carlton Whitehead Sure 🙂 Will get the 2.0 Roadmap document up soon so we can add ideas to it

@Roman I think @carlw's suggestion is good, depending on what you really need the callback for though. Here is a version where you get a notification when the value in the dropdown changes:

-.kt

But if I change the logic to open the secondary stage as follows, I can properly subscribe to secondary stage WINDOW_SHOWN event

button ("Second View") {
            setOnAction {
                val stage = Stage()
                stage.setOnShown {
                    println("Secondary $it")
                }
                val scene = Scene(SecondaryView().root)
                FX.applyStylesheetsTo(scene)
                stage.scene = scene
                stage.show()
            }
        }

@edvin can we modify the

openWindow

or

openModal

so that we can properly subscribe to stage events?

@anidotnet Interesting 🙂 Checking now.

@anidotnet The way the

onDock

callback is created for secondary windows is actually by listening to the

showing

property and then calling

onDock

. Looking for alternatives.

👍

Any reason why you don't simply use the

onDock

callback for what you want to do?

Actually, I am saving UI states (like splitpane divider position) and restoring it on opening the new window. If i put this restoration logic in onDock, splitpane's divider is not being restored.

@anidotnet Why wouldn't it be restored if you do it in onDock? Sorry if this is obvious 🙂

as far as I understood, splitpane width is still being drawn at that point of time. Because for a split second I see divider position at intended position then it shift to the default position.

if I listen to widthProperty of splitpane and writing the width of it in console, and also write to console at onDock, I see after onDock call, widthProperty is still writing

So the default is applied later, I see.

yes

A hack would be to set it in

runLater

, but that sucks of course

I tried.. but no result

The thing is,

onDock

was always intended to be called when everything was set up. I would rather delay it for the primary view than change it for the secondary views. Maybe we can find another way to deal with your issue.

the thing is for primary stage order is ok, onDock is being called when everything set up. But for secondary window it is not when I use openWindow or openModal

Hmm... If you get a callback from

stage.setOnShown

in the primary view, that would indicate that your code is running earlier than it does for the secondary view, wouldn't it?

onShown

is already called for the secondary view when

onDock

is run.

yes

sorry did not understand