@mikehearn If this is the grave...i'm in! https://system76.com/desktops/leopard

wow, nice

Hi guys! So I have a question that stems from my attempt to make a Tornadofx application that utilizes clean MVVM architecture. Specifically my question is about where we put our actions? I have a View that uses a datagrid and displays a list of Cards. Each of the cards will have a load button on them that loads the specific view that they reference. My ViewModel looks like so

class ProjectHomeViewModel: ViewModel() {
    private var projectUseCase = GetProjectsUseCase(Injector.projectDao)
    val items = FXCollections.observableArrayList<ProjectCard>()!!
    init {
        getProjects()
    }

    private fun getProjects() {
        projectUseCase.getProjects().subscribe {
            items.setAll(
                    it.map{
                        ProjectCard(it).apply{
                            loadProjectButton.action{

                            }
                        }
                    }
            )
        }
    }
}

my projectUseCase.getProjects() returns an Observable<List> which I subscribe to and map into the observableArrayList = items. I then use this items list inside my datagrid. basically, my question is, is it philosophically correct to have my ProjectCard's action present here in the viewModel? It works but i'm not sure if it's good/right...

inside this action above is where I would be loading whatever view needs to come next

if you apply two css classes to a control that change the same property, how do you control which one has precedence?

@bj0 the more specific rule will be applied. but if the precedence is the same (say .clazz1 and .clazz2 with no other directives), it's supposed to be the first one, all other things equal. if not, it's a tornadofx or javafx bug

first one listed in the

Stylesheet

?

no, specified on the element within the stylesheet - thx @Ruckus

they are both specified with

toggleClass

and a property

can you sort the rules out so that one is more specific than the other?

using and(), etc

hmm, they are both just

label and class

, not sure how to make it more specific

position in hierarchy

not that familiar with css

ex, the label in a form versus any label in the app

oh, it's currently only applied to one label in the app

you have a label {} rule and a clazz {} rule?

for example:

label and green {
            backgroundColor += Color.GREEN
        }
        label and red {
            textFill = Color.WHITE
            backgroundColor += Color.RED
        }

if

green

is bound to a 'connected' property, and

red

is bound to an error property, I would want

red

to override

green

i think it's more correct to pull off the green for a red display

otherwise you'll get yellow 🤣

tried something like that at first but couldn't get it to work so I was trying

toggleClass

that links talks about an

!important

flag, is that not implemented?

not sure. that can sometimes be confusing too. like when there's a more specific rule on an element that will ignore the !important

green and red seem exclusive. they should probably be named something logical like "success" and "error". i think if these are applied correctly you don't have to worry about any intricate precedence

how would you select them based on different properties though?

toggleClass

will not work for that, and I haven't been able to get

bindClass

to work

@bj0 here's some code that uses a listener to first clear the current set of styles on a label and then re-apply the new style. this is based on the "display" property which is driven off a toggle

i'm seeing what I can do with the observablelist...binding to one of three style lists based on the toggle

oh ok, you're clearing/adding manually, I was trying to use

bindClass

which I thought does it for you. Something like this:

val binding = nonNullObjectBinding(vm.statusProperty) {
                    <http://logger.info|logger.info> { "binding change ,$value" }
                    when (value) {
                        is ProxyStatus.Error -> Styles.error
                        ProxyStatus.Started -> Styles.active
                        else -> Stylesheet.label
                    }
                }
                bindClass(binding)

`binding`'s

onChange

listener is never firing though

i'm checking that out too. the example i posted works, but i'm shooting for something with binding