kotlinlang #tornadofx

java.lang.IllegalStateException: Not on FX application thread; currentThread = tornadofx-thread-1
	at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:279)
	at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:423)

amanda.hinchman-dominguez

09/26/2018, 2:26 PM

I'm going to have to read into javafx documentation to understand how processes work on desktop apps cause this currently means nothing to me haha

Romanow

09/26/2018, 2:27 PM

all UI interactions need to be done on the UI thread. Seems you try to change the UI in a task

➕ 2

carlw

09/26/2018, 2:28 PM

@amanda.hinchman-dominguez What's going on in the walk() function? Any JavaFX stuff including property manipulation?

amanda.hinchman-dominguez

09/26/2018, 2:29 PM

async threads are background threads, right?

carlw

09/26/2018, 2:30 PM

yep. nothing FX-related can be in there

amanda.hinchman-dominguez

09/26/2018, 2:30 PM

@carlw walk does several things. Reads the file structure of the project, parses the files into an AST breakdown and I create my own TornadoFX breakdowns that are relevant to me (i.e. detecting UI controls)

amanda.hinchman-dominguez

09/26/2018, 2:31 PM

So that makes more sense - background threads are best for API stuff and other long running processes, but I guess this is all in the UI....

carlw

09/26/2018, 2:31 PM

you'll want to strip any FX stuff that might be in there including properties

carlw

09/26/2018, 2:31 PM

there's probably nothing obvious like openWindow(), etc. but the bound properties can have listeners that result in FX things done on the FX thread

amanda.hinchman-dominguez

09/26/2018, 2:31 PM

Can you define "FX" stuff

carlw

09/26/2018, 2:32 PM

val updatedAST = SimpleStringProperty() updatedAST.value = "Finished"

amanda.hinchman-dominguez

09/26/2018, 2:32 PM

the whole code is currently on github under the

MVP

branch

amanda.hinchman-dominguez

09/26/2018, 2:33 PM

Property changes is considered to be UI processing? Makes sense

amanda.hinchman-dominguez

09/26/2018, 2:33 PM

but yikes I don't think I want to strip out that stuff

carlw

09/26/2018, 2:34 PM

maybe not now, but creating UI-agnostic AST walking code would be beneficial. more testable, etc

amanda.hinchman-dominguez

09/26/2018, 2:35 PM

ahhhh

amanda.hinchman-dominguez

09/26/2018, 2:35 PM

yeah. You're right

mikehearn

09/26/2018, 2:36 PM

amanda, it's the same on android. you have to be in the main thread to change the gui (in fact same for all graphical toolkits)

👍 1

amanda.hinchman-dominguez

09/26/2018, 2:36 PM

I know it's really badly tied in together - and I have every intention to separate it out. It's still in baby stages and I need some time to reflect and get feedback so that when I do separate it out, I have a plan and purpose behind an agnostic AST customized breakdown

mikehearn

09/26/2018, 2:36 PM

you can however create UI elements on other threads. you just can't link them into a live scene

mikehearn

09/26/2018, 2:36 PM

to get on the right thread use

Platform.runLater { .... }

😮 1

mikehearn

09/26/2018, 2:36 PM

or the tornadofx equivalent which i forgot .... just

runLater

perhaps

amanda.hinchman-dominguez

09/26/2018, 2:37 PM

Thanks so much! I can do that for NOW, but I will separate the code as soon as I get a chance.

mikehearn

09/26/2018, 2:37 PM

the lambda will execute a bit later on, when the UI is guaranteed to not be changing due to user input. so at that point you can change things around.

mikehearn

09/26/2018, 2:37 PM

the android equivalent is to schedule things using a Looper, iirc. it's been years since i did any android coding though

carlw

09/26/2018, 2:38 PM

@amanda.hinchman-dominguez @mikehearn watch out for excessive runLater use. It's sometimes misconstrued as runNow. UI events can stack up and a lot of non-UI calls can be made out-of-sequence