Empty rows.

@edvin https://gitbucket.light.kow.is/dkowis/deskScreen/blob/03057f8811fccf2083c71203684e100deea5041e/src/main/kotlin/is/kow/deskscreen/jira/JiraController.kt#L222-L226

I'm starving for lunch tho, so I'll go eat that, and then maybe work on a fake data thing so it's easier to run outside of my environment 🙂

Is

model.myTickets.add(ticket)

run on the UI thread? OK, let me know if I can run the code, we'll figure it out quickly 🙂

Does tornadofx have any methods for selecting/finding nodes in the scenegraph?

@hudsonb We have

select()

@hudsonb Most times when I see code that accesses a certain node though, the issue could be solved much nicer by either manipulating data or emitting events. I always look for that when I feel I need access to another UI node.

In a lib I've been writing I've got a port of

d3-selection

. Not happy with the API yet though wanted to see what you guys have done

Do you know here select() is defined off hand?

@hudsonb It's defined as an extension function on

Node

. It's best used with our type safe css, so you don't need to throw strings around 🙂

Ah found it, its in CSS.kt, was looking in Nodes.kt

Some things would fit in several places, but since it uses the type safe css builders we thought it fit better in CSS.kt 🙂

I would like to allow the selection of common

Node

types, then allow users to set properties on all nodes in the selection. For example

root.selectAll<Path>()

would select all

Path

nodes that are descendants of

root

as a

Selection<Path>

. I then want the to be able to set all properties of

Path

using the selection, for example:

root.selectAll<Path> {
    fill = Color.RED
}

However, I don't want to pollute

Selection<Button>

for example, with properties that apply only to `Shape`/`Path` so I was considering implementing

fill

as an extension `val`/`fun` on

Selection<Path>

. Does that make any sense? Trying to sanity check myself before spending too much time developing it.

Likewise, I would implement extension `val`/`fun` related to

Button

on

Selection<Button>

I think I've gotten RxJavaFX migrated to Java 11 and JavaFX SDK. A couple things I've learned...

JFXPanel()

is nowhere to be found 😕 I used that as a hack to start JavaFX thread. I had to call

javafx.application.Platform.startup(() ->{});

to achieve this.

I have to reimplemnent

ObservableListenerHelper

from scratch since that went away with sun packages

Other than that, upgrade was surprisingly smooth

@hudsonb Can what you're trying to do be accomplished with CSS?

@thomasnield Isn't JFXPanel() here? Different module https://openjfx.io/javadoc/11/javafx.swing/javafx/embed/swing/package-summary.html

@carlw darn it, I was looking for that thing!

@hudsonb Your case may need something special, but if it doesn't 1. Limit -- or even prevent -- UI controls from talking to other UI controls. It's an anti-pattern to use UI controls as a means to access data. Factor out the shared item and make it readily available. That can lead to a strong second-order refactor when groups of the properties start to colalesce. 2. Don't reinvent CSS. If you need a hierarchical way to style ranges of nodes, look for CSS rules rather than walking an object graph.

It's intended for selecting

Shape

subclasses, I suppose I could restrict it to that to keep things simpler. I can't think of a use case for selecting

Button

but hadnt planned on preventing it either

This article explains selections better than I ever could: https://bost.ocks.org/mike/selection/ Basically I've ported it to Kotlin/JavaFX

@hudsonb This article might give you some ideas too. JavaFX properties are used here and also in the TornadoFX toolkit to associate user-defined properties with Nodes. One thing to remember with JavaFX is that you have controls rather than a document. So, you'll often have constructs like these properties or pick correlation that aren't available when you're trying to form markup. https://courses.bekwam.net/public_tutorials/bkcourse_tornadofx_selecting.html

Thanks Ill take a look

Container classes like ListView handle the placeholder case for empty results. I'm using a special "selected" property which I can then go over later to untangle the user operation. I've also put keys and identifiers alongside the Nodes with properties.

This sample lacks only one thing -- it does not update main

ObservableList

values. Why not -- I did not find it myself yet. But I tried to look inside the

useTextField

function -- it updates value in

setOnEditCommit

, but when it runs

afterCommit

the value is not there anymore. I suspect, that I'm wrong somewhere in lines 48-54

When I debug it, fields for `cellValueFactory`:

listener

and

observable

are

null

, is it ok? I.e. after I did

column { value {{ item.item } ... }

Also the

property

inside

setOnEditCommit

(in

useTextField

function) looks similar -- fields

listener

and

observable

are

null

, but field

value

contains changed text