https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • a

    alex

    11/13/2018, 11:05 AM
    Off topic: are there any good free alternative to launch4j with support for proper windows native wrapping? Launch4j is ok, but jniGui32 header (which wraps .jar to .exe with functionality to Pin to Taskbar, display proper name in Task Manager etc) is targeting 32bit JRE only. And if TornadoFX 2.0 will target JDK11 it's no-go.
  • e

    edvin

    11/13/2018, 11:16 AM
    Yes, JavaFX is now decoupled from the JDK, and it has a separate release cycle.
  • r

    Ruckus

    11/13/2018, 5:09 PM
    @edvin If we're making breaking changes (for 2.0), would it be worth considering more significant changes? I've wondered a few times if it would be a good idea to separate the CSS into a separate project, though it has its ups and downs. I wonder it it would be worth trying to "modularize" TornadoFX more.
    👍 3
  • r

    Ruckus

    11/13/2018, 5:11 PM
    It could be worth pulling out the layout debugger, data controls, and perhaps the rest, workspace, and wizard code as well.
  • r

    Ruckus

    11/13/2018, 5:13 PM
    Granted, that would further delay the release, so maybe the discussion should be tabled for a future TornadoFX 3.0.
  • c

    carlw

    11/13/2018, 5:14 PM
    @Ruckus do you envision running tornadofx w/o type safe css? maybe just using plain .css files?
  • c

    carlw

    11/13/2018, 5:16 PM
    i think type safe css is pretty core -- it's ref'd in the App() constructor -- but a layout debugger and a controls project sound good
  • c

    carlw

    11/13/2018, 5:16 PM
    i like what the Dojo library did which was add solid controls to Core and then provide an experimental project
  • r

    Ruckus

    11/13/2018, 5:18 PM
    That's fair. I was more concerned with some of the updates to the CSS we've discussed previously that would be breaking changes. The idea was to do them for TFX2, but that's now very unlikely to happen. If it was a separate module it wouldn't be a concern.
  • r

    Ruckus

    11/13/2018, 5:22 PM
    The 
    App
    constructor is the only place I can think it would increase friction (though it would admittedly be a pretty significant increase).
  • h

    hudsonb

    11/13/2018, 5:23 PM
    +1 for separating REST out
  • c

    carlw

    11/13/2018, 7:04 PM
    @Ruckus for the css innovations, i think it's better to press ahead at this point than mix-and-match versions. i could see confusion around running the 1.0 TornadoFX CSS versus the 2.0 TornadoFX CSS . Sort of like the propagation of different property syntaxes along the way
    👍 2
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:10 PM
    should I address this?
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:10 PM
    missing listeners for async tasks and datagrid
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:15 PM
    @Ruckus I was looking at the errors coming back in the test runs and I wondered if white space was affecting it
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:15 PM
    i.e.
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:19 PM
    @Ruckus lol
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:19 PM
    the call 
    String.strip()
    is simply not being used
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:24 PM
    the reason for this is because jdk 11 now has a 
    strip()
    function as well.
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:24 PM
    I'll just override the function and it should work now
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:27 PM
    interesting, the new 
    strip
    function works as 
    trim()
    does
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:27 PM
    Copy code
    /**
     * Returns a string whose value is this string, with all leading
     * and trailing {@link Character#isWhitespace(int) white space}
     * removed.
     * <p>
     * If this {@code String} object represents an empty string,
     * or if all code points in this string are
     * {@link Character#isWhitespace(int) white space}, then an empty string
     * is returned.
     * <p>
     * Otherwise, returns a substring of this string beginning with the first
     * code point that is not a {@link Character#isWhitespace(int) white space}
     * up to and including the last code point that is not a
     * {@link Character#isWhitespace(int) white space}.
     * <p>
     * This method may be used to strip
     * {@link Character#isWhitespace(int) white space} from
     * the beginning and end of a string.
     *
     * @return  a string whose value is this string, with all leading
     *          and trailing white space removed
     *
     * @see Character#isWhitespace(int)
     *
     * @since 11
     */
    public String strip() {
        String ret = isLatin1() ? StringLatin1.strip(value)
                                : StringUTF16.strip(value);
        return ret == null ? this : ret;
    }
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:31 PM
    your tests passed now 🙂
  • r

    Ruckus

    11/13/2018, 7:31 PM
    @amanda.hinchman-dominguez Ah, good catch. Renaming would be the best bet. It's private, so not a big deal
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:31 PM
    This is another weird Java-Kotlin compatibility snag
    👍 1
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:36 PM
    @edvin sad - I can't make a new branch 😞
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:37 PM
    Copy code
    ➜ git push --set-upstream origin jdk-10-test-fixes
remote: Permission to edvin/tornadofx.git denied to ahinchman1.
fatal: unable to access '<https://github.com/edvin/tornadofx/>': The requested URL returned error: 403
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:39 PM
    do you guys normally fork the repo and then do the PR that way?
    👌 7
  • a

    amanda.hinchman-dominguez

    11/13/2018, 7:45 PM
    brb
  • a

    amanda.hinchman-dominguez

    11/13/2018, 8:02 PM
    PR is up
1...197719781979...2007Latest